Skip to content

[CI] Don't require SPIR-V Tools in Windows nightly #17961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2025
Merged

[CI] Don't require SPIR-V Tools in Windows nightly #17961

merged 1 commit into from
Apr 11, 2025

Conversation

sarnex
Copy link
Contributor

@sarnex sarnex commented Apr 10, 2025

Some people use the nightly and we don't want to require users to have it installed.

Manually verified the fix both by reproducing the original error and DependencyWalker.

Closes: #17950

@sarnex
Copy link
Contributor Author

sarnex commented Apr 10, 2025

@sarnex sarnex marked this pull request as ready for review April 10, 2025 15:34
@sarnex sarnex requested a review from a team as a code owner April 10, 2025 15:34
@sarnex sarnex changed the title [CI] Don't require SPIR-V tools in Windows nightly [CI] Don't require SPIR-V Tools in Windows nightly Apr 10, 2025
@aelovikov-intel
Copy link
Contributor

Should the same go into the release builds?

@sarnex
Copy link
Contributor Author

sarnex commented Apr 10, 2025

No idea
@KornevNikita, take?

@KornevNikita
Copy link
Contributor

No idea @KornevNikita, take?

Nope, the original patch didn't reach the sycl-rel-6-1-0 branch, so it doesn't require spirv-tools.

@sarnex
Copy link
Contributor Author

sarnex commented Apr 10, 2025

ok so prolly patch is okay as is? @aelovikov-intel

@KornevNikita
Copy link
Contributor

btw does the linux build work without spirv-tools?

@sarnex
Copy link
Contributor Author

sarnex commented Apr 10, 2025

$ ldd bin/llvm-spirv
	linux-vdso.so.1 (0x00007fff31b02000)
	libz.so.1 => /lib64/libz.so.1 (0x00007fbd166e4000)
	libstdc++.so.6 => /lib64/libstdc++.so.6 (0x00007fbd164bd000)
	libm.so.6 => /lib64/libm.so.6 (0x00007fbd163e2000)
	libgcc_s.so.1 => /lib64/libgcc_s.so.1 (0x00007fbd163c7000)
	libc.so.6 => /lib64/libc.so.6 (0x00007fbd161bd000)
	/lib64/ld-linux-x86-64.so.2 (0x00007fbd17b7a000)

Yeah seems fine

@sarnex
Copy link
Contributor Author

sarnex commented Apr 11, 2025

ping @aelovikov-intel @uditagarwal97 thanks :)

Copy link
Contributor

@uditagarwal97 uditagarwal97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sarnex sarnex merged commit ac30857 into sycl Apr 11, 2025
3 checks passed
@bader bader deleted the sarnexwin branch April 11, 2025 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows binaries release packages are unable to compile sycl programs
4 participants