Skip to content

[SYCL] Move allow-device-image-dependencies out of ModuleSplitter #18060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

steffenlarsen
Copy link
Contributor

This commit moves the "allow-device-image-dependencies" option out of the ModuleSplitter. This allows tools using the utility to control this option explicitly rather than the option bleeding into their option-space.

This commit moves the "allow-device-image-dependencies" option out of
the ModuleSplitter. This allows tools using the utility to control this
option explicitly rather than the option bleeding into their
option-space.

Signed-off-by: Larsen, Steffen <[email protected]>
Copy link
Contributor

@maarquitos14 maarquitos14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@maksimsab maksimsab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steffenlarsen steffenlarsen merged commit 17b04ba into intel:sycl Apr 22, 2025
29 of 30 checks passed
vinser52 pushed a commit to sergey-semenov/llvm that referenced this pull request Apr 22, 2025
…tel#18060)

This commit moves the "allow-device-image-dependencies" option out of
the ModuleSplitter. This allows tools using the utility to control this
option explicitly rather than the option bleeding into their
option-space.

---------

Signed-off-by: Larsen, Steffen <[email protected]>
Co-authored-by: Julian Oppermann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants