Skip to content

feat(icon): support for dynamic type #1246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Aug 9, 2023
Merged

feat(icon): support for dynamic type #1246

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
d06c6a1
feat(icon): support for dynamic type
sean-perkins Jul 21, 2023
a18b49f
chore: add tests
sean-perkins Aug 3, 2023
d9b8507
chore(): add updated snapshots
Ionitron Aug 3, 2023
19a9f93
refactor(test): root html styles
sean-perkins Aug 3, 2023
38e9cd9
Merge remote-tracking branch 'origin/sp/FW-4428' into sp/FW-4428
sean-perkins Aug 3, 2023
6435b57
chore(): add updated snapshots
Ionitron Aug 3, 2023
56851d8
chore: shrink screenshot
sean-perkins Aug 3, 2023
417e969
Merge remote-tracking branch 'origin/sp/FW-4428' into sp/FW-4428
sean-perkins Aug 3, 2023
0c9c00d
chore(): add updated snapshots
Ionitron Aug 3, 2023
c4b9313
chore: reset icon diff
sean-perkins Aug 8, 2023
95b969a
Merge remote-tracking branch 'origin/sp/FW-4428' into sp/FW-4428
sean-perkins Aug 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/components/icon/icon.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ svg {
/* Icon RTL
* -----------------------------------------------------------
*/

/**
* Safari <16.4 incorrectly reports
* that it supports :dir(rtl) when it does not.
Expand All @@ -53,7 +53,7 @@ svg {
transform: scaleX(-1);
}
}

/**
* Fallback for browsers that support
* neither :host-context nor :dir.
Expand Down Expand Up @@ -91,11 +91,11 @@ svg {
*/

:host(.icon-small) {
font-size: 18px !important;
font-size: 1.125rem !important;
}

:host(.icon-large) {
font-size: 32px !important;
font-size: 2rem !important;
}

/* Icon Colors
Expand Down