Skip to content

Change whitelist to allow for list or callable #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 14, 2019
Merged

Change whitelist to allow for list or callable #2

merged 3 commits into from
Nov 14, 2019

Conversation

rcthomas
Copy link

  • Change option name to host_whitelist
  • Replace Any() with Union() of List() or Callable
  • Update documentation to reflect change
  • Make default be ['localhost', '127.0.0.1']
  • Have whitelist check run callable if set else compare to list

@rcthomas
Copy link
Author

The problem is that traitlets 4.3.3 doesn't provide Callable().

@rcthomas
Copy link
Author

OK @jacobtomlinson looks like Yuvi had some change requests but I think I've got them all lined up here

@jacobtomlinson
Copy link
Owner

Great thanks!

@jacobtomlinson jacobtomlinson merged commit 35dd072 into jacobtomlinson:allow-remote-proxy Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rcthomas @jacobtomlinson