Global object #3415
Open
Global object #3415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaquinelio
reviewed
Mar 28, 2023
| @@ -5,7 +5,7 @@ The global object provides variables and functions that are available anywhere. | |||
|
|
|||
| In a browser it is named `window`, for Node.js it is `global`, for other environments it may have another name. | |||
|
|
|||
| Recently, `globalThis` was added to the language, as a standardized name for a global object, that should be supported across all environments. It's supported in all major browsers. | |||
| Recently, `globalThis` was added to the language as a standardized name for a global object, that should be supported across all environments. It's supported in all major browsers. | |||
There was a problem hiding this comment.
- I'm not a native eng speaker -
I tthink it needs to fix the hanging "that" too
omiting second comma
...name for a global object that should be supported...
adding something
...name for a global object, name that should be supported...
replacing it
...name for a global object, intended to be supported...
...name for a global object; it should be supported...
There was a problem hiding this comment.
I replaced that should with intended to
shallow-beach
approved these changes
Aug 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
line 8 - grammar fix
line 51 - removed unnecessary space
line 64, 72 - small improvements
newline 65