Skip to content

feat: Support ESLint 7.x #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

feat: Support ESLint 7.x #573

wants to merge 1 commit into from

Conversation

MichaelDeBoey
Copy link
Contributor

@MichaelDeBoey MichaelDeBoey commented May 9, 2020

Follow-up of #572

Rebased my previous branch, since you didn't change eslint dependency

Closes #567

@G-Rath
Copy link
Collaborator

G-Rath commented May 9, 2020

Thanks, but I'd prefer to not add more unactionable PRs to our pile, since this is covered by another PR (#567), and can't actually be done yet due to needing to drop support for node@8, and our downstream dependencies need to be updated, meaning this PR won't be actionable for least a week.

Additionally, node 14 isn't LTS yet, and we don't need to drop the .x since those are minor versions.

I appreciate your enthusiasm, but going to ask you hold fire until we've had a chance to catch up 😜

@G-Rath G-Rath closed this May 9, 2020
@MichaelDeBoey MichaelDeBoey deleted the eslint-7 branch May 9, 2020 02:06
@MichaelDeBoey
Copy link
Contributor Author

No problem, just wanted to help out 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants