Interactive watch arrow selection doesn't work on Windows.

[bookman25]

Do you want to request a feature or report a bug?
bug

What is the current behavior?
Using the new arrow selection for patterns in watch mode does not work on Windows. It correctly selects the entry but I believe because of the slashes it's not finding any tests.

Arrow selection pattern: /_Common/Upload/Html5/FileUploadSpec.ts/
Actual pattern: /_Common\\Upload\\Html5\\FileUploadSpec.ts/

What is the expected behavior?
It should find the tests based off the arrow selection.

Please provide your exact Jest configuration and mention your Jest, node, yarn/npm version and operating system.
Jest 20
Yarn 0.23.4
Windows 10

[thymikee]

Would you like to send a PR with a fix? 🙂

[bookman25]

If I find some time, I will. Created the ticket in case someone else got to it before I do.

[scottambroseio]

I had some free time today so I took a bash at fixing this, here's my findings. Here's a diff with a simple but working solution.

I don't know the code base that well at all so I'm not sure if there's a better place to do this logic.

Secondly, this change breaks one of the tests but I'm not sure how best to resolve it, as the test passing or failing depends on the operating system the test is being run on.

[thymikee]

@scottrangerio in jest-regex-util there's a replacePathSepForRegex function, I think you'll be better off using it :)

The test may be fixed with slash:

const slash = require('slash');
expect(slash(argv.testPathPattern)).toMatchSnapshot();

We use it to normalize paths in tests on Unix/Windows platforms.

[bookman25]

I'm wondering if we can normalize it instead so that watch mode would support / for windows. Right now you have to use \\ to escape slashes on windows and it's a pain. But that might involve making changes in the way the meta data about the files is stored.

[scottambroseio]

@thymikee thanks for the suggestions / input!

The replacePathSepForRegex works like a charm, but there's still an issue in the test when using slash

The test isn't actually testing a path, but a regular expression which represents a path. So rather than calling slash with a valid windows path string such as src\index.js, it's being called with the equivalent regex string src\\index.js which results in an extra / per separator.

[scottambroseio]

I've been thinking some more about a non hack way to fix the test on windows. I really like the slash idea, so I was thinking that something simple like this could do the job.

// regex-slash.js
// could be hosted as a npm module like slash, or simply included somewhere like in jest-regex-util

'use strict';

// path\\to\\file.js -> path/to/file.js
module.exports = (str: string): string => {
	return str.replace(/\\\\/g, '/');
};

usage:

const rslash = require('regex-slash');
expect(rslash(argv.testPathPattern)).toMatchSnapshot();