Skip to content

jQuery.globalEval: Document the nonce option #1131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 29, 2019
Merged

jQuery.globalEval: Document the nonce option #1131

merged 1 commit into from
Apr 29, 2019

Conversation

mgol
Copy link
Member

@mgol mgol commented Apr 15, 2019

Fixes #1123

@mgol mgol mentioned this pull request Apr 15, 2019
Closed
@mgol
Copy link
Member Author

mgol commented Apr 15, 2019

Screenshot of the page after this PR is applied:
Screen Shot 2019-04-15 at 18 04 03

dmethvin
dmethvin approved these changes Apr 18, 2019
View reviewed changes
Copy link
Member

@dmethvin dmethvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mgol mgol merged commit 05e2140 into jquery:master Apr 29, 2019
@mgol mgol deleted the globalEval branch April 29, 2019 16:49
@mgol mgol added this to the 3.0.0 milestone Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmethvin dmethvin dmethvin approved these changes

@gibson042 gibson042 gibson042 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

Core: Document passing nonce through jQuery.globalEval
3 participants
@mgol @dmethvin @gibson042