CSS: Fix duplicate "JQMIGRATE" prefix in cssProps warning #424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prefix is added by `migrateWarn()`, but in the case of cssProps, the prefix was also in the string passed as parameter.
wmfgerrit
pushed a commit
to wikimedia/mediawiki
that referenced
this pull request
May 1, 2021
This is similar to that we did for jQuery 1.9 Migrate in 2014 when we upgraded from 1.8 to 1.11 (T46740), and this will likely be the last patch in this series that's suitable for backporting to stable releases. After this, we'll start janking stuff out during the 1.37-master release, slowly working toward its removal. I've removed the patch file for now since we're far from the original now, and if any changes do get released by upstream for migrate 3.x in the next few months we'll have to apply by hand either way. (Yes, I'm volunteering to do that.) * Remove needless window.mw guard. I think I copied this from our jQuery 1.9 migrate patch, when we started the jQuery 3 migration, not realizing that by now mw.loader and startup no longer depend on jquery. jquery is loaded by an mw.loader callback (as evidenced by the need for the window.jQuery lookup pach), so mw.track always exists. If it doesn't we have bigger problems. * Remove migrateTrace code instead of disabling it. * Change `jquery-migrate` to `jquery_migrate` in mw.track call. Otherwise, the name gets transformed into an underscore later on for Prometheus, Graphite, Statsv, etc. WMF: in WikimediaEvents/statsd. * Improve PATCH comments to state upfront whether they change, add, or remove something (makes it a little easier for me if/when this needs to be rebased). * Fix duplicate "JQMIGRATE" prefix in cssProps warning. Upstream ref jquery/jquery-migrate#424. Bug: T280944 Change-Id: Ieecf02982468f1c576d2c56b43dcd59d5255bf20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prefix is added by
migrateWarn(), but in the case of cssProps, the prefix was also in the string passed as parameter.Test case: