Skip to content

Core: Make back compat disabled by default #2250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2024

Conversation

mgol
Copy link
Member

@mgol mgol commented May 11, 2024

Instead of checking whether $.uiBackCompat is explicitly set to false to skip applying backwards compatible patches, check whether $.uiBackCompat is explicitly set to true to apply those patches.

@mgol mgol added this to the 1.14.0 milestone May 11, 2024
@mgol mgol requested a review from fnagel May 11, 2024 22:41
@mgol mgol self-assigned this May 11, 2024
@mgol mgol merged commit ac8b1e4 into jquery:main May 13, 2024
22 checks passed
@mgol mgol deleted the no-back-compat-default branch May 13, 2024 16:11
@mgol mgol removed the Needs review label May 13, 2024
mgol added a commit to mgol/jquery-ui that referenced this pull request Aug 23, 2024
The "common widget" tests, checking if a widget doesn't overwrite some
core widget APIs wasn't running as it was incorrectly checking for
`$.uiBackCompat === false` instead of `$.uiBackCompat !== true` after the
default changed in jquerygh-2250.

Fixing the check uncovered that the draggable & sortable modules do
overwrite the `_trigger` method. Add an exception in the test for that;
at this stage of the project we don't plan to change the implementation.

Ref jquerygh-2250
mgol added a commit that referenced this pull request Sep 9, 2024
The "common widget" tests, checking if a widget doesn't overwrite some
core widget APIs wasn't running as it was incorrectly checking for
`$.uiBackCompat === false` instead of `$.uiBackCompat !== true` after the
default changed in gh-2250.

Fixing the check uncovered that the draggable & sortable modules do
overwrite the `_trigger` method. Add an exception in the test for that;
at this stage of the project we don't plan to change the implementation.

Closes gh-2286
Ref gh-2250
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants