immediate validation for conditional questions and validateOnRender option issue

[warmy1004]

Enhancement

I tried to use a different version of schema-form and bootstrap-decorator, and I found validation for conditional questions is immediately happening when forms load with the newest version of bootstrap-decorator. Also, I've tried to use 'validateOnRender' as a global option and a local option, but it didn't work for conditional questions.

FYI, here is version information used in my example;
angularjs & angular-sanitize : v.1.4.8
bootstrap-decorator : v.0.2.0 (I downloaded this version from https://github.com/json-schema-form/angular-schema-form-bootstrap/releases)
ObjectPath : v.1.2.1
schema-form: v.0.8.13

Expected behaviour

I expected validation for conditional questions should not be happening when forms are loaded.

Actual behaviour

It actually immediate validation is happending when forms are loaded. So, every conditional questions has 'has-error' css when they are loaded. Also, I added validateOnRender:false as a global option and a local option to prevent immediate validation manually, but it seems that it didn't work at all because of immediate validation.

However, if a different version of bootstrap-decorator, v.0.8.13 (which is provided with schema-form v.0.8.13 from https://github.com/json-schema-form/angular-schema-form/releases ) is used for the same example, this immediate validation is not happening anymore. In this case, destroyStrategy option is not working at all.

Gist/Plunker/Demo

https://plnkr.co/edit/ONljGAZ2wOB3ySRa8KBY?p=preview

Related issues

This is/maybe related to #682

@json-schema-form/angular-schema-form-lead

[Anthropic]

@warmy1004 would love to know if anything has changed with the alpha releases regarding this? Probably not, but it would help to know.

[warmy1004]

@Anthropic I tested my issues again with schema-form 1.0.0 alpha2. And I found another one thing.

I just changed schema-form version to 1.0.0 alpha2. Rest of libraries are same as before.

A validation for a radios-inline type with boolean values (true and false for titleMap's value) is acting weird. When No radio button is selected, Required error is coming. But this issue is not happening if I changed radios-inline titleMap's values to string instead of Boolean. I think false value checking is not working correctly.

Here is the plunker, so you can test it. FYI, Q4 with string values is working fine, but Q5 withboolean values is not working fine.
https://plnkr.co/edit/ONljGAZ2wOB3ySRa8KBY?p=preview

A Good thing is destroy strategy is working fine now!

If you have any question or need my help, let me know please.
Thank you.

[Anthropic]

@warmy1004 thanks, I really appreciate your effort to write issues properly and your detailed responses :)

Basically I had a hard time getting to the alpha as the tests were not working and there was not enough coverage for me to feel confident making changes to a framework I didn't write, but I'm in a good place with over a hundred test cases and code I understand now so starting to make more progress. When people make plunkers they are easier to turn into test cases, so hopefully I can use what you have done to make up some test cases and then resolve the issue.

[Anthropic]

@warmy1004 so this is fixed in the latest alpha I believe, at least the boolean question is, can you let me know if there is anything left to do on this one after alpha 4? I made it needs: more info so I don't keep opening the issue when I am waiting for a response :)

[warmy1004]

@Anthropic I don't think there is anything left here. Thank you :)

[Anthropic]

Sweet!