Skip to content

Schema validation fix for Angular 1.2 ($setDirty) #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 10, 2015
Merged

Schema validation fix for Angular 1.2 ($setDirty) #288

merged 1 commit into from
Mar 10, 2015

Conversation

adamcbuckley
Copy link
Contributor

I am required to support IE8 and am therefore limited to Angular JS 1.2

I am sure you would make this fix in due course, but I have deadlines! :-)

The Angular 1.2 version of $setDirty taken from http://makandracards.com/makandra/29625-setdirty-for-angular-1-2

I also fixed a typo - if(ngModel.$setDirty()) should be if(ngModel.$setDirty) (right?)

I am required to support IE8 and am therefore limited to Angular JS 1.2

I am sure you would make this fix in time, but I have deadlines!  :-)

The Angular 1.2 version of $setDirty taken from http://makandracards.com/makandra/29625-setdirty-for-angular-1-2
@davidlgj
Copy link
Contributor

:D Oh thanks, what a typo!

davidlgj added a commit that referenced this pull request Mar 10, 2015
Schema validation fix for Angular 1.2  ($setDirty)
@davidlgj davidlgj merged commit dc32574 into json-schema-form:development Mar 10, 2015
@adamcbuckley adamcbuckley deleted the patch-1 branch March 13, 2015 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants