Skip to content

update adr template to merge pros/cons and option descriptions #1507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

gregsdennis
Copy link
Member

Asked about this in Slack and got no sustainable objections.

Happy to discuss more.

This arrangement just makes more sense to me.

@gregsdennis gregsdennis marked this pull request as ready for review May 15, 2024 22:15
@gregsdennis gregsdennis requested review from Relequestual and a team and removed request for Relequestual May 15, 2024 22:15
Copy link
Member

@jdesrosiers jdesrosiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes more sense to me too.

@gregsdennis gregsdennis merged commit d05516c into main Jun 10, 2024
3 checks passed
@gregsdennis gregsdennis deleted the gregsdennis/adr-template-merge-pro-con-into-options branch June 10, 2024 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants