-
-
Notifications
You must be signed in to change notification settings - Fork 311
Numerous improvements to security considerations #487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@json-schema-org/spec-team anyone? |
Trying to get this published on Monday or at least sometime next week... |
dlax
approved these changes
Nov 16, 2017
Since I have no idea what it is trying to do.
This was an awkward copy-paste. Fix it up and remove the CREF reminding me to do so.
8288 is the update of 5988 Web Linking. As a link serialization format, Hyper-Schema shares those vulnerabilities.
The other parts flow much more naturally from the mention of RFC 8288 in the introductory part of the security section.
While "targetSchema" is technically never required to process a response, as the response should indicate its own schema, other target attributes in the LDO, such as the submission schema, cannot be conveyed in any way other than through the LDO. It would seem like we need a provision for determining when the LDO can be constructed, but it's not entirely clear how that should work. Put in a bit about it and a CREF to hopefully attract the attention of someone who can improve the section.
a.k.a. don't take executable content types from strangers
Update just now is a rebase to handle conflicts with the title-casing change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is probably about as much as we'll do for draft-07. We'll keep working on the security sections as the drafts progress, but this is at least as good as it has been for the last few drafts.
Addresses #456 plus various things not filed as issues.
Commit log:
See also #485 about possibly removing the "self" link bit.