Use boolean true instead of {} where possible #495
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let's emphasize the clarity of the boolean schemas as that is why they were added. Note that the default values of "definitions", "properties", and "patternProperties" is an actual empty object, not an empty schema, so those stay as they were. We were using an explicit empty schema to emphasize/document that a keyword accepts any possible value in several places, but were not using it in a few others such as "items" within the "enum" schema. Consistently make it explicit. There were no empty object subschemas in the other meta-schemas.
epoberezkin
approved these changes
Nov 17, 2017
gregsdennis
added
clarification
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #486 (sorry, @epoberezkin, I'm trying to nail down
as much as possible by end of day tomorrow/Friday, so can't
wait for your PR :-)
Let's emphasize the clarity of the boolean schemas as that is
why they were added.
Note that the default values of "definitions", "properties",
and "patternProperties" is an actual empty object, not an
empty schema, so those stay as they were.
We were using an explicit empty schema to emphasize/document
that a keyword accepts any possible value in several places,
but were not using it in a few others such as "items" within
the "enum" schema. Consistently make it explicit.
There were no empty object subschemas in the other meta-schemas.
I used ajv to validate the schema against itself, which worked fine.