Improve specs #33
Merged
Improve specs #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jul 15, 2017
| @@ -0,0 +1,11 @@ | |||
| require 'rails_helper' | |||
There was a problem hiding this comment.
Missing magic comment # frozen_string_literal: true.
spec/action_controller_spec.rb
Outdated
| it 'exposes the deserialization mapping via the jsonapi_pointers method' do | ||
| pointers = { id: '/data/id', type: '/data/type' } | ||
| describe ActionController::Base, type: :controller do | ||
| context 'when specifying a deserializable resource' do |
spec/action_controller_spec.rb
Outdated
| RSpec.describe ActionController::Base do | ||
| it 'exposes the deserialization mapping via the jsonapi_pointers method' do | ||
| pointers = { id: '/data/id', type: '/data/type' } | ||
| describe ActionController::Base, type: :controller do |
houndci-bot
reviewed
Jul 15, 2017
spec/action_controller_spec.rb
Outdated
| 'data' => { | ||
| 'id' => '1', | ||
| 'type' => 'users', | ||
| 'attributes' => { 'name' => 'Lucas' } } |
There was a problem hiding this comment.
Closing hash brace must be on the line after the last hash element when opening brace is on a separate line from the first hash element.
| env: { | ||
| JSONAPI::Rails::ActionController::JSONAPI_POINTERS_KEY => pointers | ||
| describe ActionController::Base, type: :controller do | ||
| describe '.deserializable_resource' do |
| OpenStruct.new( | ||
| env: { | ||
| JSONAPI::Rails::ActionController::JSONAPI_POINTERS_KEY => pointers | ||
| describe ActionController::Base, type: :controller do |
houndci-bot
reviewed
Jul 15, 2017
| OpenStruct.new( | ||
| env: { | ||
| JSONAPI::Rails::ActionController::JSONAPI_POINTERS_KEY => pointers | ||
| describe ActionController::Base, type: :controller do |
mdeutsch
pushed a commit
to patientslikeme/jsonapi-rails
that referenced
this pull request
Jul 21, 2017
* upstream/master: Improve specs (jsonapi-rb#33) Expose deserialization reverse mapping in controllers (jsonapi-rb#29) Update jsonapi-rb to v0.2.1. (jsonapi-rb#32) Add dummy app temp files to .gitignore (jsonapi-rb#30) Deal with jsonapi-serializable no longer calling to_json (jsonapi-rb#26)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.