Conditionally include controller mixin #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jul 25, 2017
| if ::Rails::VERSION::MAJOR >= 5 | ||
| ::ActionDispatch::Request.parameter_parsers[:jsonapi] = PARSER | ||
| else | ||
| ::ActionDispatch::ParamsParser::DEFAULT_PARSERS[Mime[:jsonapi]] = PARSER |
| @@ -0,0 +1,6 @@ | |||
| JSONAPI::Rails.configure do |config| | |||
There was a problem hiding this comment.
Missing magic comment # frozen_string_literal: true.
| source_root File.expand_path('../templates', __FILE__) | ||
|
|
||
| def copy_initializer_file | ||
| copy_file 'initializer.rb', "config/initializers/jsonapi.rb" |
There was a problem hiding this comment.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
| @@ -0,0 +1,7 @@ | |||
| class InitializerGenerator < Rails::Generators::Base | |||
There was a problem hiding this comment.
Missing top-level class documentation comment.
Missing magic comment # frozen_string_literal: true.
houndci-bot
reviewed
Jul 25, 2017
| if ::Rails::VERSION::MAJOR >= 5 | ||
| ::ActionDispatch::Request.parameter_parsers[:jsonapi] = PARSER | ||
| else | ||
| ::ActionDispatch::ParamsParser::DEFAULT_PARSERS[Mime[:jsonapi]] = PARSER |
| @@ -0,0 +1,6 @@ | |||
| JSONAPI::Rails.configure do |config| | |||
There was a problem hiding this comment.
Missing magic comment # frozen_string_literal: true.
| source_root File.expand_path('../templates', __FILE__) | ||
|
|
||
| def copy_initializer_file | ||
| copy_file 'initializer.rb', "config/initializers/jsonapi.rb" |
There was a problem hiding this comment.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
| @@ -0,0 +1,7 @@ | |||
| class InitializerGenerator < Rails::Generators::Base | |||
There was a problem hiding this comment.
Missing top-level class documentation comment.
Missing magic comment # frozen_string_literal: true.
beauby
force-pushed
the
conditionally-include-controller-mixin
branch
from
bd6a1a4 to
9825729
Compare
houndci-bot
reviewed
Jul 25, 2017
| initializer 'jsonapi-rails.action_controller' do | ||
| ActiveSupport.on_load(:action_controller) do | ||
| include ::JSONAPI::Rails::Controller | ||
| initializer 'jsonapi.init', after: :load_config_initializers do |
mdeutsch
pushed a commit
to patientslikeme/jsonapi-rails
that referenced
this pull request
Jul 25, 2017
* upstream/master: Conditionally include controller mixin (jsonapi-rb#40) Add initializer generator. (jsonapi-rb#39) Add ActiveSupport::Notifications instrumentation. (jsonapi-rb#41) Add library configuration object (jsonapi-rb#17) Rename JSONAPI::Rails::ActionController to JSONAPI::Rails::Controller. (jsonapi-rb#38) Add hook for default jsonapi object. (jsonapi-rb#37) Add hook for default exposures. (jsonapi-rb#36) Add hook for automatic pagination links. (jsonapi-rb#35) Upgrade to new jsonapi-deserializable version. (jsonapi-rb#34) Prepare for v0.2.1 release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.