-
Notifications
You must be signed in to change notification settings - Fork 35
Remove .to_json from renderer #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #56 +/- ##
=======================================
Coverage 99.55% 99.55%
=======================================
Files 17 17
Lines 453 453
=======================================
Hits 451 451
Misses 2 2
Continue to review full report at Codecov.
|
@vasilakisfil Quick update: the reason I'm holding off merging this is simply that it's a breaking API change (though it should only impact people who use jsonapi-rb as a standalone ruby lib), and there are a few non-breaking changes that I'd like to release before |
@beauby makes sense to me 👍 |
just curious, when do you think this will make it into repo? Perhaps in the meantime, we can do
That way you won't break the api, but people can access the hash directly? |
@Aryk Sorry for the late reply – this should make it in tomorrow. |
@vasilakisfil Would you mind rebasing? Edit: Nevermind, this new GH feature for fixing merge conflicts is awesome. |
Hi @vasilakisfil – would you mind fixing the new test that's broken by this PR? (Basically remove the |
Sure, I can do it later today! |
@beauby fixed! |
@vasilakisfil Finally merging – thanks! |
Renderer returns a hash instead, fixes #55