Skip to content

autoCloseArguments support in @ParameterizedTest breaks existing tests #2706

Closed
@sbrannen

Description

@sbrannen

Overview

Having autoCloseArguments default to true is a breaking change for arguments that are shared between parameterized test invocations.

In the Spring Framework test suite, we have three @ParameterizedTest methods (in PathMatchingUrlHandlerMappingTests and ClientHttpConnectorTests) that hang indefinitely while running against JUnit 5.8 snapshots.

Declaring @ParameterizedTest(autoCloseArguments = false) solves the problem, but this is technically a regression and, more importantly, the average user will not even know where to begin debugging such failures.

Deliverables

Document that autoCloseArguments in @ParameterizedTest is a potentially breaking change in:

  • Javadoc
  • Release Notes
  • User Guide

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions