ENH: Add tqdm to skopt optimization #282
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crazy25000
commented
Mar 20, 2021
kernc
reviewed
Mar 21, 2021
kernc
reviewed
Mar 21, 2021
kernc
reviewed
Mar 21, 2021
|
Thanks @crazy25000! Apologies for the wait. 🎉 |
|
@kernc no worries, we're all busy doing something 😄 |
Benouare
pushed a commit
to Benouare/backtesting.py
that referenced
this pull request
Jun 21, 2021
* ENH: Add tqdm to skopt * MNT: Format long line * ENH: Pass max_tries as total len, update desc wording * ENH: Replace skopt class with variable * ENH: Pass single skopt callback directly instead of in a list * ENH: Check if tqdm object has update attr * MNT: Update tqdm description text * FMT: Use single quotes * MNT: Refactor pbar to use iter * MNT: Refactor to meet max line length * bikeshedding Fixes kernc#280
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #280
Added
tqdmprogress bar toskoptoptimization runs .TODO:
3.0.126.2.0Write new test to account for failing coverage thresholdScreenshot in Jupyterlab.
Skopt optimizationsis for the change in this PR, plays nicely with other progress bars if you use them.