Skip to content

Upgrade some more dev dependencies #505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 20, 2024
Merged

Conversation

ExplodingCabbage
Copy link
Collaborator

No description provided.

@ExplodingCabbage
Copy link
Collaborator Author

Awww, man. This affects the built files in ways I simply don't understand:

--- dist-master/diff.js	2024-03-19 17:54:44.215622691 +0000
+++ dist/diff.js	2024-03-19 17:55:19.022355585 +0000
@@ -1,8 +1,8 @@
 (function (global, factory) {
   typeof exports === 'object' && typeof module !== 'undefined' ? factory(exports) :
   typeof define === 'function' && define.amd ? define(['exports'], factory) :
-  (global = global || self, factory(global.Diff = {}));
-}(this, (function (exports) { 'use strict';
+  (global = typeof globalThis !== 'undefined' ? globalThis : global || self, factory(global.Diff = {}));
+})(this, (function (exports) { 'use strict';
 
   function Diff() {}
   Diff.prototype = {
@@ -1827,6 +1827,4 @@
   exports.reversePatch = reversePatch;
   exports.structuredPatch = structuredPatch;
 
-  Object.defineProperty(exports, '__esModule', { value: true });
-
-})));
+}));

I guess I need to get some understanding of JavaScript module systems to evaluate if this breaks stuff. Argh!

@ExplodingCabbage ExplodingCabbage marked this pull request as draft March 19, 2024 17:57
@ExplodingCabbage
Copy link
Collaborator Author

I'm just gonna roll forward with this, keep updating stuff, and before doing a release, figure out how to test that jsdiff still works with all module systems.

@ExplodingCabbage ExplodingCabbage marked this pull request as ready for review March 20, 2024 10:37
@ExplodingCabbage ExplodingCabbage merged commit 84b5c9e into master Mar 20, 2024
@ExplodingCabbage ExplodingCabbage deleted the upgrade-more-stuff branch March 20, 2024 10:37
ExplodingCabbage added a commit that referenced this pull request Aug 20, 2024
Should've been done as part of #505, but I missed it
ExplodingCabbage added a commit that referenced this pull request Aug 20, 2024
Should've been done as part of #505, but I missed it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant