UI: Update KRAIL title color to use theme color #686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Mar 29, 2025
ksharma-xyz
changed the title
ksharma-xyz
force-pushed
the
03-29-display_krail_text_in_theme_color
branch
from
1bd046d to
8c63ded
Compare
ksharma-xyz
force-pushed
the
03-29-update_text_colors_for_light_and_dark_mode_to_increase_contrast_and_also_for_a11y_to_support_diff._theme_color_styles
branch
3 times, most recently
from
fa45391 to
b3c6225
Compare
ksharma-xyz
force-pushed
the
03-29-display_krail_text_in_theme_color
branch
from
8c63ded to
2efadda
Compare
|
On Clicking logo
|
ksharma-xyz
force-pushed
the
03-29-update_text_colors_for_light_and_dark_mode_to_increase_contrast_and_also_for_a11y_to_support_diff._theme_color_styles
branch
3 times, most recently
from
ae2740e to
0973ddb
Compare
ksharma-xyz
changed the base branch from
03-29-update_text_colors_for_light_and_dark_mode_to_increase_contrast_and_also_for_a11y_to_support_diff._theme_color_styles
to
graphite-base/686
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Updated the KRAIL title text color in the SavedTripsScreen to use the theme color.
What changed?
LocalThemeColor,hexToComposeColor, andgetForegroundColorfrom the taj packageLocalThemeColor.currentcolor = themeColor.hexToComposeColor()How to test?
Why make this change?
This change ensures the title text color is consistent with the app's theming system, improving visual coherence and following the design guidelines for the application.