creating Configuration disables all HTTP debug logging

[rittneje]

Debug mode is disabled automatically in the constructor.

python/kubernetes/client/configuration.py

Line 126 in 6b01c95

self.debug = False

Doing so disables HTTP debug logging for the whole application.

python/kubernetes/client/configuration.py

Lines 265 to 270 in 6b01c95

	# if debug status is False, turn off debug logging,
	# setting log level to default `logging.WARNING`
	for _, logger in six.iteritems(self.logger):
	logger.setLevel(logging.WARNING)
	# turn off httplib debug
	httplib.HTTPConnection.debuglevel = 0

This means that even HTTP requests that have nothing to do with k8s won't be logged anymore. This is neither expected or desirable. Enabling/disabling debug logging should not tamper with the global HTTPConnection.debuglevel setting in any way.

Furthermore, it looks like two separate Configurations will still share their loggers. Consequently, you cannot really have one that has debug disabled and another with debug enabled. Thus it shouldn't be presented as an instance field.

[rittneje]

It seems the issues run even deeper. It uses two loggers: "client" and "urllib3". The first is way too generic and could easily conflict with some other package. It should instead be "kubernetes" or similar. The latter should not be touched at all, because this package may not be the only thing using urllib3.

[rittneje]

I'm not sure how amenable this library is to breaking changes, but I request that the debug property be removed from Configuration entirely. Instead, clients should do logging.getLogger('kubernetes').setLevel(logging.DEBUG). This library should also be fixed to use logging.getLogger(__name__), as is standard practice.

[roycaihw]

/assign

[roycaihw]

Thanks for reporting the issue. The configuration module is generated by the openapi-generator: https://github.com/OpenAPITools/openapi-generator/blob/master/modules/openapi-generator/src/main/resources/python/configuration.mustache

@rittneje Would you mind filing an issue in openapi-generator? Once it's fixed in the upstream code generator, we can regenerate the client to get the fix.

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[rittneje]

/remove-lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[rittneje]

/remove-lifecycle stale