Changes made in configuration.py to accept environmental variables #2390
Conversation
What type of PR is this? /kind bug What this PR does / why we need it: This PRs will read environment variables assigned for proxy and no_proxy. Which issue(s) this PR fixes: Fixes kubernetes-client#2321 Special notes for your reviewer: Unit test is added kubernetes\base\stream\ws_client_test.py Does this PR introduce a user-facing change? None Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: None
Update configuration.py What type of PR is this? /kind bug What this PR does / why we need it: This PRs will read environment variables assigned for proxy and no_proxy. Which issue(s) this PR fixes: Fixes kubernetes-client#2321 Special notes for your reviewer: Unit test is added kubernetes\base\stream\ws_client_test.py Does this PR introduce a user-facing change? None Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: None
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
kind/bug
|
Keywords which can automatically close issues and at(@) or hashtag(#) mentions are not allowed in commit messages. The list of commits with invalid commit messages:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
k8s-ci-robot
added
do-not-merge/release-note-label-needed
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: p172913 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/L
What type of PR is this?
/kind bug
What this PR does / why we need it:
This PRs will read environment variables assigned for proxy and no_proxy.
Which issue(s) this PR fixes:
Fixes #2321
Special notes for your reviewer:
Unit test is added kubernetes\base\stream\ws_client_test.py
Does this PR introduce a user-facing change?
None
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
None