[feat: gw api][bug fix] generate sg rules using listener protocols #4198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
zac-nixon
reviewed
Jun 2, 2025
| equality.Semantic.DeepEqual(gwClassOld.DeletionTimestamp.IsZero(), gwClassNew.DeletionTimestamp.IsZero()) { | ||
| return | ||
| } | ||
|
|
||
| h.logger.V(1).Info("enqueue gatewayclass update event", "gatewayclass", gwClassNew.Name) | ||
| h.enqueueImpactedGateways(ctx, gwClassNew, queue) |
There was a problem hiding this comment.
This is going to re-queue all gateways every sync period. Is the idea that we want this to happen in order to support lb conf changes?
There was a problem hiding this comment.
Yes we want to enqueue gateways when lb conf changes happens.
zac-nixon
reviewed
Jun 2, 2025
zac-nixon
reviewed
Jun 2, 2025
…ot route protocols
zac-nixon
approved these changes
Jun 3, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: shraddhabang, zac-nixon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
README.md, or thedocsdirectory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯