-
Notifications
You must be signed in to change notification settings - Fork 447
Match AzureASOManaged references on group and kind, not version #5662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Match AzureASOManaged references on group and kind, not version #5662
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5662 +/- ##
==========================================
- Coverage 53.26% 53.19% -0.08%
==========================================
Files 272 272
Lines 29529 29585 +56
==========================================
+ Hits 15730 15738 +8
- Misses 12984 13027 +43
- Partials 815 820 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
/lgtm |
LGTM label has been added. Git tree hash: 17183d22947a54a76efc12a1b05f866078ed0b7f
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: willie-yao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
1 similar comment
/retest |
Consecutive distinct flake counter: 3 /retest |
4 /retest |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Places that check for references to AzureASOManaged resources were checking API group, version, and kind. As we prepare to additionally serve a v1beta1 version of those resources, those checks need to be adapted to accept either v1alpha1 or v1beta1 as expected versions. These changes skip checking the version entirely, since group and kind are sufficient to determine what the underlying type of an object is.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs:
Release note: