Skip to content

Match AzureASOManaged references on group and kind, not version #5662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2025

Conversation

nojnhuh
Copy link
Contributor

@nojnhuh nojnhuh commented May 31, 2025

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

Places that check for references to AzureASOManaged resources were checking API group, version, and kind. As we prepare to additionally serve a v1beta1 version of those resources, those checks need to be adapted to accept either v1alpha1 or v1beta1 as expected versions. These changes skip checking the version entirely, since group and kind are sufficient to determine what the underlying type of an object is.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • cherry-pick candidate

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels May 31, 2025
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 31, 2025
@k8s-ci-robot k8s-ci-robot requested review from marosset and mboersma May 31, 2025 04:58
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 31, 2025
Copy link

codecov bot commented May 31, 2025

Codecov Report

Attention: Patch coverage is 63.63636% with 4 lines in your changes missing coverage. Please review.

Project coverage is 53.19%. Comparing base (d9da21b) to head (f8cc719).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
controllers/agentpooladopt_controller.go 50.00% 1 Missing ⚠️
controllers/azureasomanagedcluster_controller.go 80.00% 1 Missing ⚠️
...trollers/azureasomanagedcontrolplane_controller.go 50.00% 1 Missing ⚠️
controllers/managedclusteradopt_controller.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5662      +/-   ##
==========================================
- Coverage   53.26%   53.19%   -0.08%     
==========================================
  Files         272      272              
  Lines       29529    29585      +56     
==========================================
+ Hits        15730    15738       +8     
- Misses      12984    13027      +43     
- Partials      815      820       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alimaazamat
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 2, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 17183d22947a54a76efc12a1b05f866078ed0b7f

Copy link
Contributor

@willie-yao willie-yao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: willie-yao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 2, 2025
@nojnhuh
Copy link
Contributor Author

nojnhuh commented Jun 3, 2025

/retest

1 similar comment
@nojnhuh
Copy link
Contributor Author

nojnhuh commented Jun 3, 2025

/retest

@nojnhuh
Copy link
Contributor Author

nojnhuh commented Jun 3, 2025

Consecutive distinct flake counter: 3

/retest

@nojnhuh
Copy link
Contributor Author

nojnhuh commented Jun 3, 2025

Consecutive distinct flake counter: 3

/retest

4

/retest

@k8s-ci-robot k8s-ci-robot merged commit ee37fc7 into kubernetes-sigs:main Jun 3, 2025
21 of 22 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Jun 3, 2025
@github-project-automation github-project-automation bot moved this from Todo to Done in CAPZ Planning Jun 3, 2025
@nojnhuh nojnhuh deleted the asoapi-version-match branch June 3, 2025 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants