Skip to content

integration: describe how to fall back on non-xdg-portal file chooser #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

johanmalm
Copy link
Member

Related to: labwc/labwc#2300

Cc @jp7677

Chooser:

1. Set the environment variable `GDK_DEBUG=no-portals`
2. Create a `/usr/share/xdg-desktop-portal/labwc-portals.conf` with the line `org.freedesktop.impl.portal.FileChooser=none`
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be better to advise to create a configuration file in the current user home (https://flatpak.github.io/xdg-desktop-portal/docs/portals.conf.html) based on https://github.com/labwc/labwc/blob/master/data/labwc-portals.conf with the mentioned addition.
Chances are there that a system configuration file already exists, at least that is how Labwc is packaged for Fedora.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay. Good suggestions. Only read this after below fixup. Will carry on tomorrow.

Copy link

@Bluey26 Bluey26 Nov 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, since it is a GTK issue, and gtk apps are in all the wayland compositors, maybe portals.conf would be preffered instead of labwc-portals.conf. I agree about the file location, preferring ~/.config/xdg-desktop-portal/ ($XDG_CONFIG_HOME/xdg-desktop-portal/, as mentioned in the link shared).

Not sure if the issue happens in other compositors, its just a suggestion.

@johanmalm
Copy link
Member Author

Thanks. How about this then?

Copy link

@jp7677 jp7677 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Small suggestion.

xdg-portal technology which may not work depending on your system setup. There
are at least two ways to fallback to a 'normal' File Chooser:

1. Set the environment variable `GDK_DEBUG=no-portals`
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: ..

in e.g. `~/.config/labwc/environment`

@johanmalm johanmalm merged commit 4d97a42 into main Nov 22, 2024
@johanmalm johanmalm deleted the gtk-file-chooser branch November 22, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants