Skip to content

Update .env.example to fix MILVUS_URI default value #13140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 12, 2025

Conversation

codingjaguar
Copy link
Contributor

@codingjaguar codingjaguar commented Feb 2, 2025

Summary

The MILVUS_URI with localhost is not reachable from another docker container. Changed to the special DNS name host.docker.internal to fix the problem.

See detailed issue report in
https://discord.com/channels/1160323594396635310/1335159004598370376/1335281419240607884

Screenshots

Before After
before after

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Fix the documentation about Milvus URI setting. dify-docs#472
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. dependencies Pull requests that update a dependency file labels Feb 2, 2025
@crazywoola
Copy link
Member

We fix the CI in #13142, please rebase the origin/main :)

The MILVUS_URI with localhost is not reachable from another docker container. Changed to the special DNS name `host.docker.internal` to fix the problem.

See detailed issue report in
https://discord.com/channels/1160323594396635310/1335159004598370376/1335281419240607884
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Feb 12, 2025
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Feb 12, 2025
@codingjaguar
Copy link
Contributor Author

We fix the CI in #13142, please rebase the origin/main :)

@crazywoola Done. Could you give it a review? Thanks!

@codingjaguar
Copy link
Contributor Author

@crazywoola Another unrelated question: I saw MILVUS_ENABLE_HYBRID_SEARCH=False and image: milvusdb/milvus:v2.5.0-beta. Is that due to full text search in milvus 2.5.0 was a beta feature?

Now full text search in Milvus is mature with 2.5.4. Is that feasible to update the default config to milvusdb/milvus:v2.5.4 and turn on MILVUS_ENABLE_HYBRID_SEARCH by default?

@crazywoola
Copy link
Member

@crazywoola Another unrelated question: I saw MILVUS_ENABLE_HYBRID_SEARCH=False and image: milvusdb/milvus:v2.5.0-beta. Is that due to full text search in milvus 2.5.0 was a beta feature?

Now full text search in Milvus is mature with 2.5.4. Is that feasible to update the default config to milvusdb/milvus:v2.5.4 and turn on MILVUS_ENABLE_HYBRID_SEARCH by default?

By turning this on will break previous installed dify I think.

@codingjaguar
Copy link
Contributor Author

@crazywoola Another unrelated question: I saw MILVUS_ENABLE_HYBRID_SEARCH=False and image: milvusdb/milvus:v2.5.0-beta. Is that due to full text search in milvus 2.5.0 was a beta feature?

Now full text search in Milvus is mature with 2.5.4. Is that feasible to update the default config to milvusdb/milvus:v2.5.4 and turn on MILVUS_ENABLE_HYBRID_SEARCH by default?

By turning this on will break previous installed dify I think.

Got it. Then please ignore that. Can this PR get a review?

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Mar 6, 2025
@zc277584121
Copy link
Contributor

@crazywoola hello, the checks have passed, can you please take a review

@zc277584121
Copy link
Contributor

@zxhlyh @crazywoola please review it, many thanks

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 12, 2025
@crazywoola crazywoola merged commit 74f66d3 into langgenius:main Mar 12, 2025
8 checks passed
@crazywoola
Copy link
Member

Done @zc277584121 @codingjaguar

parambharat pushed a commit to parambharat/dify that referenced this pull request Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants