Skip to content

feat: env MAX_TOOLS_NUM #15431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 12, 2025
Merged

feat: env MAX_TOOLS_NUM #15431

merged 5 commits into from
Mar 12, 2025

Conversation

rafaelncarvalho
Copy link
Contributor

@rafaelncarvalho rafaelncarvalho commented Mar 10, 2025

Summary

This PR modifies the MAX_TOOLS_NUM constant in config/index.ts to be configurable via an environment variable. Instead of a hard-coded value of 10, it now uses the value of NEXT_PUBLIC_MAX_TOOLS_NUM environment variable or defaults to 10 if the variable is not set.

Resolves #8605

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. ☕️ typescript Pull request that update TypeScript code. 💪 enhancement New feature or request labels Mar 10, 2025
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Mar 11, 2025
@rafaelncarvalho
Copy link
Contributor Author

@crazywoola I’ve made the requested changes. Thanks for the clarification!

crazywoola
crazywoola previously approved these changes Mar 12, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 12, 2025
Copy link
Member

@crazywoola crazywoola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crazywoola crazywoola merged commit 1d5ea80 into langgenius:main Mar 12, 2025
9 checks passed
Scorpion1221 added a commit to yybht155/dify that referenced this pull request Mar 12, 2025
* commit '5019547d33eefa870786e5f981907ff2314a639a': (128 commits)
  fix: can not test custom tool (langgenius#15606)
  fix: no attribute error (langgenius#15597)
  fix: trace return null cause page crash (langgenius#15588)
  fix: set marketplace feature to false in feature_service.py (langgenius#15578)
  feat: env MAX_TOOLS_NUM (langgenius#15431)
  chore: use TenantAccountRole instead of TenantAccountJoinRole (langgenius#15514)
  fix: dataset editor (langgenius#15218)
  fix:message api doc (langgenius#15568)
  chore: remove unused parameter (langgenius#15558)
  feat: add debounced enter key submission to install form (langgenius#15445) (langgenius#15542)
  fix: invoke_error is not callable (langgenius#15555)
  fix: workflow loop node break conditions (langgenius#15549)
  fix: remove size prop in PlanBadge component because UpgradeBtn size … (langgenius#15544)
  feat: add click-away and mounting logic to agent setting component (langgenius#15521)
  chore: update opendal version (langgenius#14343)
  fix: nesting of conditional branches causing streaming output error (langgenius#14065)
  fix: update version to 1.0.1 in configuration and Docker files (langgenius#15478)
  fix notion page display (langgenius#15508)
  support workspace billing info (langgenius#15510)
  fix: update placeholders in version info modal to indicate optional field (langgenius#15499)
  ...

# Conflicts:
#	api/poetry.lock
#	web/pnpm-lock.yaml
parambharat pushed a commit to parambharat/dify that referenced this pull request Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💪 enhancement New feature or request lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files. ☕️ typescript Pull request that update TypeScript code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

An agent can only be configured with 10 tools at most?
2 participants