-
Notifications
You must be signed in to change notification settings - Fork 14.1k
feat: env MAX_TOOLS_NUM #15431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
feat: env MAX_TOOLS_NUM #15431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crazywoola
reviewed
Mar 11, 2025
@crazywoola I’ve made the requested changes. Thanks for the clarification! |
crazywoola
previously approved these changes
Mar 12, 2025
crazywoola
approved these changes
Mar 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Scorpion1221
added a commit
to yybht155/dify
that referenced
this pull request
Mar 12, 2025
* commit '5019547d33eefa870786e5f981907ff2314a639a': (128 commits) fix: can not test custom tool (langgenius#15606) fix: no attribute error (langgenius#15597) fix: trace return null cause page crash (langgenius#15588) fix: set marketplace feature to false in feature_service.py (langgenius#15578) feat: env MAX_TOOLS_NUM (langgenius#15431) chore: use TenantAccountRole instead of TenantAccountJoinRole (langgenius#15514) fix: dataset editor (langgenius#15218) fix:message api doc (langgenius#15568) chore: remove unused parameter (langgenius#15558) feat: add debounced enter key submission to install form (langgenius#15445) (langgenius#15542) fix: invoke_error is not callable (langgenius#15555) fix: workflow loop node break conditions (langgenius#15549) fix: remove size prop in PlanBadge component because UpgradeBtn size … (langgenius#15544) feat: add click-away and mounting logic to agent setting component (langgenius#15521) chore: update opendal version (langgenius#14343) fix: nesting of conditional branches causing streaming output error (langgenius#14065) fix: update version to 1.0.1 in configuration and Docker files (langgenius#15478) fix notion page display (langgenius#15508) support workspace billing info (langgenius#15510) fix: update placeholders in version info modal to indicate optional field (langgenius#15499) ... # Conflicts: # api/poetry.lock # web/pnpm-lock.yaml
This was referenced Mar 17, 2025
parambharat
pushed a commit
to parambharat/dify
that referenced
this pull request
Mar 31, 2025
Co-authored-by: crazywoola <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
💪 enhancement
New feature or request
lgtm
This PR has been approved by a maintainer
size:S
This PR changes 10-29 lines, ignoring generated files.
☕️ typescript
Pull request that update TypeScript code.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR modifies the
MAX_TOOLS_NUM
constant inconfig/index.ts
to be configurable via an environment variable. Instead of a hard-coded value of 10, it now uses the value ofNEXT_PUBLIC_MAX_TOOLS_NUM
environment variable or defaults to 10 if the variable is not set.Resolves #8605
Checklist
Important
Please review the checklist below before submitting your pull request.
dev/reformat
(backend) andcd web && npx lint-staged
(frontend) to appease the lint gods