Skip to content

fix the major and minor version of stub types declaration with build date stripped #16709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 25, 2025

Conversation

bowenliang123
Copy link
Contributor

@bowenliang123 bowenliang123 commented Mar 25, 2025

Summary

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

  • to close simplify stub types declaration #16708
  • simplify stub types declaration, as the detailed version is updated daily and should be locked by lockfile
    • e.g. simplify types-html5lib = "~1.1.11.20241018" to types-html5lib = "~1.1.11"
  • minor impacts in poetry lockfile, only the whole file hash is changed.

Tip

Close issue syntax: Fixes #<issue number> or Resolves #<issue number>, see documentation for more details.

Screenshots

Before After
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@bowenliang123 bowenliang123 marked this pull request as ready for review March 25, 2025 06:31
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. dependencies Pull requests that update a dependency file labels Mar 25, 2025
@bowenliang123
Copy link
Contributor Author

cc @laipz8200 @crazywoola

laipz8200
laipz8200 previously approved these changes Mar 25, 2025
Copy link
Member

@laipz8200 laipz8200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 25, 2025
@bowenliang123 bowenliang123 changed the title simplify stub types declaration fix the major and minor version of stub types declaration with build date stripped Mar 25, 2025
@crazywoola crazywoola merged commit e0fc7f6 into langgenius:main Mar 25, 2025
8 checks passed
@bowenliang123 bowenliang123 deleted the simplify-stubs branch March 25, 2025 13:24
parambharat pushed a commit to parambharat/dify that referenced this pull request Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

simplify stub types declaration
3 participants