Skip to content

feat: add search params to url #17684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 10, 2025
Merged

feat: add search params to url #17684

merged 6 commits into from
Apr 10, 2025

Conversation

WTW0313
Copy link
Collaborator

@WTW0313 WTW0313 commented Apr 9, 2025

Summary

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Tip

Close issue syntax: Fixes #<issue number> or Resolves #<issue number>, see documentation for more details.

Screenshots

Before After
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@WTW0313 WTW0313 changed the title Feat/add search params to url feat: add search params to url Apr 9, 2025
@WTW0313 WTW0313 requested a review from Copilot April 9, 2025 08:33
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

web/app/components/plugins/marketplace/utils.ts:137

  • Ensure that PLUGIN_TYPE_SEARCH_MAP is imported in this file to avoid potential reference errors.
if (category && category !== PLUGIN_TYPE_SEARCH_MAP.all)

@WTW0313 WTW0313 marked this pull request as ready for review April 10, 2025 03:00
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. 💪 enhancement New feature or request 📚 documentation Improvements or additions to documentation labels Apr 10, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 10, 2025
@WTW0313 WTW0313 merged commit 63aab5c into main Apr 10, 2025
8 checks passed
@WTW0313 WTW0313 deleted the feat/add-search-params-to-url branch April 10, 2025 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📚 documentation Improvements or additions to documentation 💪 enhancement New feature or request lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants