Fix external knowledge Issues: (#17685) #17843
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use metadata.document_id or title for external KB retrieval to fix citation grouping
Summary
Resolves #17685
When processing external knowledge base retrieval results, the
document_id
was not assigned, resulting in all retrieved results having adocument_id
of null. However, the front-end page happens to group and display cited files based on thedocument_id
, leading to a maximum of only one file citation being displayed during the conversation.Solution: When processing external knowledge base retrieval results, attempt to obtain
metadata.document_id
from the external knowledge base's returned results. If there is nodocument_id
, then takemetadata.title
as thedocument_id
.Screenshots
Checklist
Important
Please review the checklist below before submitting your pull request.
dev/reformat
(backend) andcd web && npx lint-staged
(frontend) to appease the lint gods