Skip to content

Fix external knowledge Issues: (#17685) #17843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2025

Conversation

briqt
Copy link
Contributor

@briqt briqt commented Apr 11, 2025

Use metadata.document_id or title for external KB retrieval to fix citation grouping

Summary

Resolves #17685

When processing external knowledge base retrieval results, the document_id was not assigned, resulting in all retrieved results having a document_id of null. However, the front-end page happens to group and display cited files based on the document_id, leading to a maximum of only one file citation being displayed during the conversation.

Solution: When processing external knowledge base retrieval results, attempt to obtain metadata.document_id from the external knowledge base's returned results. If there is no document_id, then take metadata.title as the document_id.

Screenshots

Before After
image image

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

 document_id field is empty when using external knowledge
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Apr 11, 2025
@crazywoola crazywoola requested a review from JohnJyong April 11, 2025 07:14
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 11, 2025
@JohnJyong
Copy link
Collaborator

LGTM

@crazywoola crazywoola merged commit 91cfa90 into langgenius:main Apr 11, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
3 participants