Skip to content

fix: bump the minimal node requirement to fix eslint fail #17938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 21, 2025
Merged

fix: bump the minimal node requirement to fix eslint fail #17938

merged 2 commits into from
Apr 21, 2025

Conversation

CorrectRoadH
Copy link
Contributor

@CorrectRoadH CorrectRoadH commented Apr 12, 2025 •
edited
Loading

Summary

Fixes #17414

Tip

Close issue syntax: Fixes #<issue number> or Resolves #<issue number>, see documentation for more details.

Screenshots

Before After
CleanShot 2025-04-12 at 21 54 18@2x CleanShot 2025-04-12 at 21 54 58@2x

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. dependencies Pull requests that update a dependency file 📚 documentation Improvements or additions to documentation labels Apr 12, 2025
@crazywoola crazywoola requested a review from iamjoel April 13, 2025 02:31
@CorrectRoadH CorrectRoadH changed the title fix: bump the mini node requirement to fix eslint fail fix: bump the minimal node requirement to fix eslint fail Apr 13, 2025
@iamjoel
Copy link
Collaborator

iamjoel commented Apr 14, 2025

We will test this for a week.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 17, 2025
@iamjoel iamjoel merged commit 9bd8e62 into langgenius:main Apr 21, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazywoola crazywoola crazywoola approved these changes

@iamjoel iamjoel Awaiting requested review from iamjoel

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file 📚 documentation Improvements or additions to documentation lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

web lint SyntaxError: Unexpected token 'with'
3 participants
@CorrectRoadH @iamjoel @crazywoola