Skip to content

Add analyzer_params config for milvus vectordb #18180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 17, 2025
Merged

Add analyzer_params config for milvus vectordb #18180

merged 4 commits into from
Apr 17, 2025

Conversation

rainsoft
Copy link
Contributor

@rainsoft rainsoft commented Apr 16, 2025 •
edited by crazywoola
Loading

Summary

Add analyzer_params config for milvus vectordb

fix #16859

Screenshots

Before After
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. 👻 feat:rag Embedding related issue, like qdrant, weaviate, milvus, vector database. labels Apr 16, 2025
@crazywoola
Copy link
Member

Please fix the tests in CI

@rainsoft
Copy link
Contributor Author

Resolve type mismatch in analyzer_params assignment

@crazywoola
Copy link
Member

Still have the ci issues here.

@rainsoft
Copy link
Contributor Author

fix ci error of "replace Dict with dict"

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 17, 2025
@crazywoola crazywoola merged commit e8d98e3 into langgenius:main Apr 17, 2025
8 checks passed
@rainsoft rainsoft deleted the add_analyzer_params_config_milvus branch April 17, 2025 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazywoola crazywoola crazywoola approved these changes

Assignees
No one assigned
Labels
👻 feat:rag Embedding related issue, like qdrant, weaviate, milvus, vector database. lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add analyzer_params config for milvus vectordb
2 participants
@rainsoft @crazywoola