Skip to content

fix: clickjacking #18516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 22, 2025
Merged

fix: clickjacking #18516

merged 5 commits into from
Apr 22, 2025

Conversation

iamjoel
Copy link
Collaborator

@iamjoel iamjoel commented Apr 22, 2025

A Clickjacking vulnerability has been identified on the default setup of DIFY application, allowing malicious actors to trick users into clicking on elements of the web page without their knowledge or consent. This can lead to unauthorized actions being performed, potentially compromising the security and privacy of users.

Screenshots

Before After
image image

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. 🐞 bug Something isn't working labels Apr 22, 2025
zxhlyh
zxhlyh previously approved these changes Apr 22, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 22, 2025
crazywoola
crazywoola previously approved these changes Apr 22, 2025
zxhlyh
zxhlyh previously approved these changes Apr 22, 2025
@iamjoel iamjoel dismissed stale reviews from zxhlyh and crazywoola via d3d6fbe April 22, 2025 08:30
zxhlyh
zxhlyh previously approved these changes Apr 22, 2025
zxhlyh
zxhlyh previously approved these changes Apr 22, 2025
@iamjoel iamjoel merged commit 3737e0b into main Apr 22, 2025
13 checks passed
@iamjoel iamjoel deleted the fix/Clickjacking branch April 22, 2025 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants