Skip to content

Support of Laravel 12 and Laravel Doctrine ORM 3.1 #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 14 commits into from

Conversation

R3VoLuT1OneR
Copy link
Contributor

Hello,

Just letting you know have working on refactoring this package to support Laravel 12 and new Laravel Doctrine ORM version. As I see the this repository is not active and not supporting latest versions even of Laravel Doctrine ORM.

Main changes:

  • Replaced mapping implementation with Attributes.
  • Using of the workbench for testing functionality including persistence with Doctrine.
  • Update documentation

Have a plans to integrate a new entity type "Organisation Role" will allow to have separate organisation based permissions.

I think it will be good to merge the changes to this repository and allow other to benefit from the changes as well.
Releasing a new version 2.0 makes sense in this case I think.

Open to introduce any changes if needed.

@TomHAnderson
Copy link
Contributor

Thanks you! I'm in charge of the ORM library but nobody has been paying attention to this one.

A new major version is needed for this. I'm creating a 2.0.x branch to merge this but not creating a release yet.

A fork isn't necessary because I'm open to making your changes official.
https://github.com/laravel-doctrine/acl/pull/67/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R10

A couple changes I would like to see:

This isn't a library I use and with your approved enthusiasm I'm open to any changes you see fit for version 2.0.
I'll be here to review your PRs.

@TomHAnderson TomHAnderson changed the base branch from 1.x to 2.0.x April 25, 2025 21:21
Copy link
Contributor

@TomHAnderson TomHAnderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments but nothing in the code except the Doctrine Coding Standard

composer.json Outdated
},
{
"name": "Pavlo Zhytomyrskyi",
"email": "[email protected]"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@R3VoLuT1OneR
Copy link
Contributor Author

@TomHAnderson
Thanks, nice to meet you!

I will begin preparing the necessary fixes.

Additionally, I plan to rebase the commits. This branch will focus on adding support for Doctrine 3 and Laravel 12.

I will submit a separate Pull Request specifically for Laravel 11 support to 1.x.
My goal is to ensure the library continues to support older versions that utilize annotations.

I believe this library is underused, due to less comprehensive documentation.
But it's actually having good functionality.

@TomHAnderson
Copy link
Contributor

I'll leave this branch unmerged for now. It would behoove you to create a new branch on your repo so I don't have to pull from main. If you make a PR from a branch other than main, I'll just close this in favor of the new one.

@TomHAnderson
Copy link
Contributor

I'll get started on the documentation conversion.

@TomHAnderson
Copy link
Contributor

https://laravel-doctrine-acl.readthedocs.io/en/latest/index.html

@R3VoLuT1OneR R3VoLuT1OneR force-pushed the main branch 3 times, most recently from a44d82e to 6b4865a Compare April 26, 2025 16:45
Copy link

codecov bot commented Apr 26, 2025

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@R3VoLuT1OneR
Copy link
Contributor Author

@TomHAnderson
Created a new pull request #73

@TomHAnderson
Copy link
Contributor

Superseded by #73

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants