-
Notifications
You must be signed in to change notification settings - Fork 33
Support of Laravel 12 and Laravel Doctrine ORM 3.1 #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks you! I'm in charge of the ORM library but nobody has been paying attention to this one. A new major version is needed for this. I'm creating a 2.0.x branch to merge this but not creating a release yet. A fork isn't necessary because I'm open to making your changes official. A couple changes I would like to see:
This isn't a library I use and with your approved enthusiasm I'm open to any changes you see fit for version 2.0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments but nothing in the code except the Doctrine Coding Standard
composer.json
Outdated
}, | ||
{ | ||
"name": "Pavlo Zhytomyrskyi", | ||
"email": "[email protected]" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@TomHAnderson I will begin preparing the necessary fixes. Additionally, I plan to rebase the commits. This branch will focus on adding support for Doctrine 3 and Laravel 12. I will submit a separate Pull Request specifically for Laravel 11 support to 1.x. I believe this library is underused, due to less comprehensive documentation. |
I'll leave this branch unmerged for now. It would behoove you to create a new branch on your repo so I don't have to pull from |
I'll get started on the documentation conversion. |
a44d82e
to
6b4865a
Compare
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
@TomHAnderson |
Superseded by #73 |
Hello,
Just letting you know have working on refactoring this package to support Laravel 12 and new Laravel Doctrine ORM version. As I see the this repository is not active and not supporting latest versions even of Laravel Doctrine ORM.
Main changes:
Have a plans to integrate a new entity type "Organisation Role" will allow to have separate organisation based permissions.
I think it will be good to merge the changes to this repository and allow other to benefit from the changes as well.
Releasing a new version 2.0 makes sense in this case I think.
Open to introduce any changes if needed.