[5.6] Fix assertCookie() now cookies are unserialized by default #25149
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the security fix,
EncryptCookies
middleware now has$serialize = false
out-of-the-box so cookietests now fail with
app('encrypter')->decrypt($cookieValue, $unserialize = true)
always called byassertCookie()
.This breaks the method signature by adding another optional argument but today's changes also (necessarily) do so
¯\_(ツ)_/¯
.To avoid changing the method signature in 5.5 & 5.6, an alternate solution is to hardcode
assertCookie()
to false:And if anyone wishes to keep:
in their
EncryptCookies
middleware, they must add macros toTestReponse
with their own assertion methods.