Skip to content

fix:[lar-169] mail bug for ThreadConverted #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 5, 2025
Merged

fix:[lar-169] mail bug for ThreadConverted #303

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/Notifications/ThreadConvertedByCreator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ final class ThreadConvertedByCreator extends Notification
{
use Queueable;

public function __construct(public Thread $thread) {}
public function __construct(protected Thread $thread) {}

/**
* Get the notification's delivery channels.
Expand All @@ -31,7 +31,7 @@ public function via(object $notifiable): array
public function toMail(object $notifiable): MailMessage
{
return (new MailMessage)
->subject(__('pages/discussion.converted_by_creator'))
->subject(__('pages/discussion.converted_by_creator.subject'))
->line(__('pages/discussion.converted_by_creator.converted_line'))
->line(__('pages/discussion.converted_by_creator.thread_title').$this->thread->title)
->action(__('pages/discussion.converted_by_creator.action_text'), route('forum.show', $this->thread))
Expand Down
Loading