Refactoring code

Makefile

@@ -0,0 +1,9 @@
+.PHONY: helpers
+helpers:
+	php artisan ide-helper:generate
+	php artisan ide-helper:models -F helpers/ModelHelper.php -M
+	php artisan ide-helper:meta
+
+.PHONY: stan
+stan:
+	composer stan

app/Actions/Fortify/CreateNewUser.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace App\Actions\Fortify;
 
 use App\Models\User;

app/Actions/Fortify/PasswordValidationRules.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace App\Actions\Fortify;
 
 use Illuminate\Validation\Rules;

app/Actions/Fortify/ResetUserPassword.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace App\Actions\Fortify;
 
 use Illuminate\Support\Facades\Hash;
@@ -19,7 +21,7 @@ class ResetUserPassword implements ResetsUserPasswords
      *
      * @throws \Illuminate\Validation\ValidationException
      */
-    public function reset($user, array $input)
+    public function reset($user, array $input): void
     {
         Validator::make($input, [
             'password' => $this->passwordRules(),

app/Actions/Fortify/UpdateUserPassword.php

@@ -1,7 +1,10 @@
 <?php
 
+declare(strict_types=1);
+
 namespace App\Actions\Fortify;
 
+use App\Models\User;
 use Illuminate\Support\Facades\Hash;
 use Illuminate\Support\Facades\Validator;
 use Laravel\Fortify\Contracts\UpdatesUserPasswords;
@@ -11,15 +14,11 @@ class UpdateUserPassword implements UpdatesUserPasswords
     use PasswordValidationRules;
 
     /**
-     * Validate and update the user's password.
-     *
-     * @param  mixed  $user
-     * @param  array  $input
-     * @return void
      *
-     * @throws \Illuminate\Validation\ValidationException
+     * @param  User  $user
+     * @param  string[]  $input
      */
-    public function update($user, array $input)
+    public function update(User $user, array $input): void
     {
         Validator::make($input, [
             'current_password' => ['required', 'string'],

app/Actions/Fortify/UpdateUserProfileInformation.php

@@ -1,24 +1,21 @@
 <?php
 
+declare(strict_types=1);
+
 namespace App\Actions\Fortify;
 
-use Illuminate\Contracts\Auth\MustVerifyEmail;
+use App\Models\User;
 use Illuminate\Support\Facades\Validator;
 use Illuminate\Validation\Rule;
 use Laravel\Fortify\Contracts\UpdatesUserProfileInformation;
 
 class UpdateUserProfileInformation implements UpdatesUserProfileInformation
 {
     /**
-     * Validate and update the given user's profile information.
-     *
-     * @param  mixed  $user
-     * @param  array  $input<string, string>
-     * @return void
-     *
-     * @throws \Illuminate\Validation\ValidationException
+     * @param  User $user
+     * @param  string[]  $input
      */
-    public function update($user, array $input)
+    public function update(User $user, array $input): void
     {
         Validator::make($input, [
             'name' => ['required', 'string', 'max:255'],
@@ -32,8 +29,7 @@ public function update($user, array $input)
             ],
         ])->validateWithBag('updateProfileInformation');
 
-        if ($input['email'] !== $user->email &&
-            $user instanceof MustVerifyEmail) {
+        if ($input['email'] !== $user->email) {
             $this->updateVerifiedUser($user, $input);
         } else {
             $user->forceFill([
@@ -44,13 +40,10 @@ public function update($user, array $input)
     }
 
     /**
-     * Update the given verified user's profile information.
-     *
      * @param  mixed  $user
-     * @param  array  $input
-     * @return void
+     * @param  string[]  $input
      */
-    protected function updateVerifiedUser($user, array $input)
+    protected function updateVerifiedUser(User $user, array $input): void
     {
         $user->forceFill([
             'name' => $input['name'],

app/Actions/Replies/CreateReply.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace App\Actions\Replies;
 
 use App\Events\CommentWasAdded;

app/Actions/Replies/LikeReply.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace App\Actions\Replies;
 
 use App\Models\Reaction;

app/Console/Commands/AssignUserRole.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace App\Console\Commands;
 
 use App\Models\User;

app/Console/Commands/Cleanup/DeleteOldUnverifiedUsers.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace App\Console\Commands\Cleanup;
 
 use App\Models\User;

app/Console/Commands/CreateAdminUser.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace App\Console\Commands;
 
 use App\Models\User;

app/Console/Commands/GenerateSitemap.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace App\Console\Commands;
 
 use Illuminate\Console\Command;
@@ -14,6 +16,9 @@ class GenerateSitemap extends Command
 
     protected $description = 'Crawl the site to generate a sitemap.xml file';
 
+    /**
+     * @var array|string[]
+     */
     private array $noIndexPaths = [
         '',
         '/forum/*',

app/Console/Commands/PostArticleToTelegram.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace App\Console\Commands;
 
 use App\Models\Article;

app/Console/Commands/PostArticleToTwitter.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace App\Console\Commands;
 
 use App\Models\Article;

app/Console/Commands/PublishArticles.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace App\Console\Commands;
 
 use App\Models\Article;

app/Console/Commands/SendUnVerifiedMails.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace App\Console\Commands;
 
 use App\Mail\SendMailToUnVerifiedUsers;

app/Console/Commands/SendWelcomeMailToUsers.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace App\Console\Commands;
 
 use App\Models\User;

app/Console/Commands/UpdateUserBestRepliesPoints.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace App\Console\Commands;
 
 use App\Gamify\Points\BestReply;
@@ -12,11 +14,11 @@ class UpdateUserBestRepliesPoints extends Command
 
     protected $description = 'Updating users bests replies reputation points';
 
-    public function handle()
+    public function handle(): void
     {
         $this->info('Updating users bests replies reputations...');
 
-        $resolvedThread = Thread::with('solutionReply')->resolved()->get();
+        $resolvedThread = Thread::resolved()->with('solutionReply')->get();
 
         foreach ($resolvedThread as $thread) {
             givePoint(new BestReply($thread->solutionReply));

app/Console/Commands/UpdateUserDiscussionsPoints.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace App\Console\Commands;
 
 use App\Gamify\Points\DiscussionCreated;
@@ -12,7 +14,7 @@ class UpdateUserDiscussionsPoints extends Command
 
     protected $description = 'Update users discussions reputation points';
 
-    public function handle()
+    public function handle(): void
     {
         $this->info('Updating users discussions reputations...');
 

app/Console/Commands/UpdateUserPostsPoints.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace App\Console\Commands;
 
 use App\Gamify\Points\PostCreated;
@@ -12,7 +14,7 @@ class UpdateUserPostsPoints extends Command
 
     protected $description = 'Update users posts reputation points';
 
-    public function handle()
+    public function handle(): void
     {
         $this->info('Updating users posts reputations...');
 

app/Console/Commands/UpdateUserRepliesPoints.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace App\Console\Commands;
 
 use App\Gamify\Points\ReplyCreated;
@@ -12,7 +14,7 @@ class UpdateUserRepliesPoints extends Command
 
     protected $description = 'Updating users replies reputation points';
 
-    public function handle()
+    public function handle(): void
     {
         $this->info('Updating users bests replies reputations...');
 

app/Console/Commands/UpdateUserThreadsPoints.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace App\Console\Commands;
 
 use App\Gamify\Points\ThreadCreated;
@@ -12,7 +14,7 @@ class UpdateUserThreadsPoints extends Command
 
     protected $description = 'Update users threads reputation points';
 
-    public function handle()
+    public function handle(): void
     {
         $this->info('Updating users threads reputations...');
 

app/Console/Kernel.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace App\Console;
 
 use Illuminate\Console\Scheduling\Schedule;
@@ -10,7 +12,7 @@ class Kernel extends ConsoleKernel
     /**
      * The Artisan commands provided by your application.
      *
-     * @var array
+     * @var string[]
      */
     protected $commands = [
         \App\Console\Commands\Cleanup\DeleteOldUnverifiedUsers::class,
@@ -26,7 +28,6 @@ protected function schedule(Schedule $schedule): void
             $schedule->command('lcm:post-article-to-telegram')->everyFourHours();
             $schedule->command('lcm:send-unverified-mails')->weeklyOn(1, '8:00');
             $schedule->command('sitemap:generate')->daily();
-            $schedule->command(\Spatie\Health\Commands\RunHealthChecksCommand::class)->everyMinute();
         }
     }
 

app/Contracts/ReactableInterface.php

@@ -1,13 +1,18 @@
 <?php
 
+declare(strict_types=1);
+
 namespace App\Contracts;
 
+use Illuminate\Database\Eloquent\Collection;
+use Illuminate\Database\Eloquent\Relations\MorphToMany;
+
 interface ReactableInterface
 {
     /**
      * Returns an Eloquent collection of reactions to the current item.
      */
-    public function reactions();
+    public function reactions(): MorphToMany;
 
     /**
      * Returns a collection of objects. Every object has a name and a count.
@@ -23,5 +28,5 @@ public function reactions();
      *          $reaction->count
      *      }
      */
-    public function getReactionsSummary();
+    public function getReactionsSummary(): Collection;
 }

app/Contracts/ReplyInterface.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace App\Contracts;
 
 use Illuminate\Database\Eloquent\Collection;

app/Contracts/SubscribeInterface.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace App\Contracts;
 
 use App\Models\User;