Nightly build began to fail on sqlx

[nyurik]

Bug Description

Due to a recent rustc regression (rated as critical), sqlx can no longer compile on the latest nightly. This is NOT due to anything in the SQLX crate. This issue exists only to track the upstream bug, and will be closed as soon as upstream is fixed. See rust-lang/rust#117598

Minimal Reproduction

$ rustup toolchain install nightly
$ rustup update
$ cargo +nightly build

Info

• SQLx version: latest git and 0.7
• SQLx features enabled: default or "sqlite", "runtime-tokio"
• Database server and version: n/a
• Operating system: Linux Mint
• rustc --version: rustc 1.75.0-nightly (4b85902b4 2023-11-04)

Error

   Compiling sqlx-core v0.7.2 (/home/nyurik/dev/rust/sqlx/sqlx-core)
warning: unused import: `WriteBuffer`
  --> sqlx-core/src/net/socket/mod.rs:10:36
   |
10 | pub use buffered::{BufferedSocket, WriteBuffer};
   |                                    ^^^^^^^^^^^
   |
   = note: `#[warn(unused_imports)]` on by default

error[E0308]: mismatched types
   --> sqlx-core/src/any/database.rs:32:21
    |
32  |     type Database = Any;
    |                     ^^^ lifetime mismatch
    |
    = note: expected associated type `<any::database::Any as HasValueRef<'r>>::Database`
               found associated type `<any::database::Any as HasValueRef<'r>>::Database`
note: the required lifetime does not necessarily outlive the lifetime `'r` as defined here
   --> sqlx-core/src/any/database.rs:31:6
    |
31  | impl<'r> HasValueRef<'r> for Any {
    |      ^^
note: the lifetime requirement is introduced here
   --> sqlx-core/src/database.rs:119:20
    |
119 |     type Database: Database;
    |                    ^^^^^^^^

error[E0308]: mismatched types
   --> sqlx-core/src/any/database.rs:32:21
    |
32  |     type Database = Any;
    |                     ^^^ lifetime mismatch
    |
    = note: expected associated type `<any::database::Any as HasValueRef<'r>>::Database`
               found associated type `<any::database::Any as HasValueRef<'r>>::Database`
note: the lifetime `'r` as defined here doesn't meet the lifetime requirements
   --> sqlx-core/src/any/database.rs:31:6
    |
31  | impl<'r> HasValueRef<'r> for Any {
    |      ^^
note: the lifetime requirement is introduced here
   --> sqlx-core/src/database.rs:119:20
    |
119 |     type Database: Database;
    |                    ^^^^^^^^

error[E0308]: mismatched types
   --> sqlx-core/src/any/database.rs:38:21
    |
38  |     type Database = Any;
    |                     ^^^ lifetime mismatch
    |
    = note: expected associated type `<any::database::Any as HasStatement<'q>>::Database`
               found associated type `<any::database::Any as HasStatement<'q>>::Database`
note: the required lifetime does not necessarily outlive the lifetime `'q` as defined here
   --> sqlx-core/src/any/database.rs:37:6
    |
37  | impl<'q> HasStatement<'q> for Any {
    |      ^^
note: the lifetime requirement is introduced here
   --> sqlx-core/src/database.rs:153:20
    |
153 |     type Database: Database;
    |                    ^^^^^^^^

error[E0308]: mismatched types
   --> sqlx-core/src/any/database.rs:38:21
    |
38  |     type Database = Any;
    |                     ^^^ lifetime mismatch
    |
    = note: expected associated type `<any::database::Any as HasStatement<'q>>::Database`
               found associated type `<any::database::Any as HasStatement<'q>>::Database`
note: the lifetime `'q` as defined here doesn't meet the lifetime requirements
   --> sqlx-core/src/any/database.rs:37:6
    |
37  | impl<'q> HasStatement<'q> for Any {
    |      ^^
note: the lifetime requirement is introduced here
   --> sqlx-core/src/database.rs:153:20
    |
153 |     type Database: Database;
    |                    ^^^^^^^^

error[E0308]: mismatched types
   --> sqlx-core/src/any/database.rs:44:21
    |
44  |     type Database = Any;
    |                     ^^^ lifetime mismatch
    |
    = note: expected associated type `<any::database::Any as HasArguments<'q>>::Database`
               found associated type `<any::database::Any as HasArguments<'q>>::Database`
note: the required lifetime does not necessarily outlive the lifetime `'q` as defined here
   --> sqlx-core/src/any/database.rs:43:6
    |
43  | impl<'q> HasArguments<'q> for Any {
    |      ^^
note: the lifetime requirement is introduced here
   --> sqlx-core/src/database.rs:135:20
    |
135 |     type Database: Database;
    |                    ^^^^^^^^

error[E0308]: mismatched types
   --> sqlx-core/src/any/database.rs:44:21
    |
44  |     type Database = Any;
    |                     ^^^ lifetime mismatch
    |
    = note: expected associated type `<any::database::Any as HasArguments<'q>>::Database`
               found associated type `<any::database::Any as HasArguments<'q>>::Database`
note: the lifetime `'q` as defined here doesn't meet the lifetime requirements
   --> sqlx-core/src/any/database.rs:43:6
    |
43  | impl<'q> HasArguments<'q> for Any {
    |      ^^
note: the lifetime requirement is introduced here
   --> sqlx-core/src/database.rs:135:20
    |
135 |     type Database: Database;
    |                    ^^^^^^^^

For more information about this error, try `rustc --explain E0308`.
warning: `sqlx-core` (lib) generated 1 warning (1 duplicate)
error: could not compile `sqlx-core` (lib) due to 6 previous errors; 1 warning emitted
warning: build failed, waiting for other jobs to finish...
warning: `sqlx-core` (lib) generated 1 warning
error: could not compile `sqlx-core` (lib) due to 6 previous errors; 1 warning emitted

[HTGAzureX1212]

Just encountered the very same error today.

[nyurik]

I also filed a short version of this bug at rust-lang/rust#117598

[abonander]

I'll leave this open for informational purposes but it sounds like it needs to be fixed upstream.

Feel free to close when that happens.

[lirannl]

Can confirm this also applies to rust beta (1.74) and stable (1.73), and sqlx 0.7.1 and 0.7.0, regardless of locked-ness.

[rakshith-ravi]

Can confirm this also applies to rust beta (1.74) and stable (1.73), and sqlx 0.7.1 and 0.7.0, regardless of locked-ness.

Stable rust seems to work fine. I haven't tested beta, but I am able to build just fine on stable

Edit: Are you sure there's no rust-toolchain.toml that's forcing nightly by any chance?

[nyurik]

This is not a sqlx issue, but lots of people might see this bug if they try to build their own code with the nightly toolchain due to a recent Rust regression. I updated the description to clarify that.