Implement minKeys option and update babel-eslint to @babel/eslint-parser #27
+378
−402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giacomocerquone
changed the title
|
@leo-buneev Any followup for this? Seems like a useful change that could benefit a lot of repos. |
|
@leo-buneev Apologies for pinging again, would be great to get an update. |
|
@leo-buneev is anyone else available to maintain this package? It's incredibly useful and it would really be awesome if we could get a bit more oversight for pull requests |
|
I would love to see |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The install process was stuck due to a 404 while trying to fetch this package: eslint-plugin-tyrecheck.
I've removed babel-eslint since it's known to be deprecated and I've integrated @babel/eslint-parser instead which require a babel.config.js file instead.
I reintroduced the commented tests for the minKeys option
Test are passing