Error thrown on compiling using a sourcemap and autoprefix in Node v14

[coreyoss]

Hello,

I recently upgraded to Node v4.17.5 and it seems a newly added exception there is breaking my Less build.

I'm using less v4.1.1 and less-plugin-autoprefix v2.0.0. To recreate the issue I've -

1. Installed the above packages globally
2. Created a less file (test.less) with the following content -

p {
    color: blue;
}

3. On the command line, run -
   lessc test.less test.css --source-map=test.css.map --autoprefix='defaults'

On running this, I get the errors -

internal/fs/utils.js:793
  throw new ERR_INVALID_ARG_TYPE(
  ^

TypeError [ERR_INVALID_ARG_TYPE]: The "data" argument must be of type string or an instance of Buffer, TypedArray, or DataView. Received an instance of SourceMapGenerator
    at writeFile (fs.js:1487:5)
    at go$writeFile (/usr/lib/node_modules/less/node_modules/graceful-fs/graceful-fs.js:138:14)
    at Object.writeFile (/usr/lib/node_modules/less/node_modules/graceful-fs/graceful-fs.js:135:12)
    at writeSourceMap (/usr/lib/node_modules/less/bin/lessc:183:10)
    at writeSourceMapIfNeeded (/usr/lib/node_modules/less/bin/lessc:207:7)
    at /usr/lib/node_modules/less/bin/lessc:299:11
    at /usr/lib/node_modules/less/bin/lessc:237:11
    at /usr/lib/node_modules/less/node_modules/graceful-fs/graceful-fs.js:143:16
    at /usr/lib/node_modules/less/node_modules/graceful-fs/graceful-fs.js:61:14
    at FSReqCallback.oncomplete (fs.js:180:23) {
  code: 'ERR_INVALID_ARG_TYPE'
}

Interestingly, I don't get the error if I exclude the sourcemap or the autoprefix. Eg. lessc test.less test.css --source-map=test.css.map works and so does lessc test.less test.css --autoprefix='defaults'.

I downgraded to Node v12.22.5 and this works fine.

Any help in resolving this would be appreciated!

Thanks,
Corey

[iChenLei]

Thanks for bug report.

[iChenLei]

https://nodejs.org/dist/latest-v14.x/docs/api/fs.html#fs_fs_writefile_file_data_options_callback

Version	Changes
v14.0.0	The data parameter won't coerce unsupported input to strings anymore.

When you run command line ⬇️

lessc test.less test.css --source-map=test.css.map --autoprefix='defaults'

less.js/packages/less/bin/lessc

Lines 180 to 185 in dc3a310

	var filename = sourceMapOptions.sourceMapFullFilename;
	ensureDirectory(filename);
	fs.writeFile(filename, output, 'utf8', function (err) {
	if (err) {
	var description = 'Error: ';

The second parameter is a instance of SourceMapGenerator and not string, so crashed when you use node v14.

only add source-map args

lessc test.less test.css --source-map=test.css.map

Why node v12 works fine ?

Node 12 fs module's wirteFile will auto coerce unsupported input to strings and SourceMapGenerator self has a toString func, so work as expected.

So the reason is clear. @coreyoss Are you interested in this bugfix ? It'a very easy bug to fix, only need add toString for source-map generation, of course unit test is required ! source-map and plugin test code is here:

less.js/packages/less/Gruntfile.js

Lines 259 to 276 in 3173fdd

	plugin: {
	command: [
	`node bin/lessc --clean-css="--s1 --advanced" ${lessFolder}/_main/lazy-eval.less tmp/lazy-eval.css`,
	"cd lib",
	`node ../bin/lessc --clean-css="--s1 --advanced" ../${lessFolder}/_main/lazy-eval.less ../tmp/lazy-eval.css`,
	"cd ..",
	// Test multiple plugins
	`node bin/lessc --plugin=clean-css="--s1 --advanced" --plugin=autoprefix="ie 11,Edge >= 13,Chrome >= 47,Firefox >= 45,iOS >= 9.2,Safari >= 9" ${lessFolder}/_main/lazy-eval.less tmp/lazy-eval.css`
	].join(" && ")
	},
	"sourcemap-test": {
	// quoted value doesn't seem to get picked up by time-grunt, or isn't output, at least; maybe just "sourcemap" is fine?
	command: [
	`node bin/lessc --source-map=test/sourcemaps/maps/import-map.map ${lessFolder}/_main/import.less test/sourcemaps/import.css`,
	`node bin/lessc --source-map ${lessFolder}/sourcemaps/basic.less test/sourcemaps/basic.css`
	].join(" && ")
	}
	},

Good first issue for you, thanks ! PR welcome, I will help you to be less contributor !

cc @matthew-dean

[gzb1128]

@iChenLei
hiii, i am new to github, i am interested in this issue.
when i finish, i will open a PR, including bug fix and unit tests mentioned above or more. is it enough?
thx

[iChenLei]

@gzb1128 Thank you.