Skip to content

✨ feat: deprecation warnings for Less + monorepo chores #4319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 27 commits into from
Mar 1, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
d57210e
Added deprecation warnings
matthew-dean Aug 28, 2023
fcdad74
Remove warning about combinator
matthew-dean Sep 20, 2023
844117e
Switch to PNPM
matthew-dean Feb 28, 2025
864e255
Update local dependencies
matthew-dean Feb 28, 2025
01a97b6
Merge branch 'master' into chore/add-deprecation-warnings
matthew-dean Feb 28, 2025
cc5d53d
Remove inner dist folder
matthew-dean Feb 28, 2025
2b88e4e
Create symbolic link to dist folder
matthew-dean Feb 28, 2025
9e073b8
Flip dist folders
matthew-dean Feb 28, 2025
8d06c64
Create symbolic link in root
matthew-dean Feb 28, 2025
015e8ac
Add contributors
matthew-dean Feb 28, 2025
ddc908f
:busts_in_silhouette: Add @matthew-dean as a contributor
matthew-dean Feb 28, 2025
6ccb322
:busts_in_silhouette: Add @cloudhead as a contributor
matthew-dean Feb 28, 2025
9956966
:busts_in_silhouette: Add @lukeapage as a contributor
matthew-dean Feb 28, 2025
e0ec2f0
:busts_in_silhouette: Add @seven-phases-max as a contributor
matthew-dean Feb 28, 2025
17f448d
:busts_in_silhouette: Add @iChenLei as a contributor
matthew-dean Feb 28, 2025
869490b
:busts_in_silhouette: Add @puckowski as a contributor
matthew-dean Feb 28, 2025
1b80741
Add more contributors
matthew-dean Feb 28, 2025
a389382
Finish deprecation warnings
matthew-dean Feb 28, 2025
fc0ac5b
Resolve deletions and such
matthew-dean Feb 28, 2025
8583b48
Fix symbolic link
matthew-dean Feb 28, 2025
d0c0de3
Update ci.yml to use PNPM
matthew-dean Feb 28, 2025
f603dff
Update ci.yml to use PNPM
matthew-dean Feb 28, 2025
f86e400
Merge branch 'chore/add-deprecation-warnings' of github.com:matthew-d…
matthew-dean Feb 28, 2025
9c7fc27
Refine CI versions
matthew-dean Feb 28, 2025
be42bc7
Fix node printed version
matthew-dean Feb 28, 2025
13d1098
Better fix for #4258 and #4292
matthew-dean Feb 28, 2025
f18c70c
Re-enable other tests
matthew-dean Feb 28, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
77 changes: 77 additions & 0 deletions .all-contributorsrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,77 @@
{
"projectName": "Less.js",
"projectOwner": "The Less CSS Team",
"repoType": "github",
"repoHost": "https://github.com/less/less.js",
"files": [
"README.md"
],
"imageSize": 100,
"commit": true,
"commitConvention": "gitmoji",
"contributors": [
{
"login": "matthew-dean",
"name": "Matthew Dean",
"avatar_url": "https://avatars.githubusercontent.com/u/414752?v=4",
"profile": "https://github.com/matthew-dean",
"contributions": [
"code",
"doc",
"maintenance",
"projectManagement"
]
},
{
"login": "cloudhead",
"name": "Alexis Sellier",
"avatar_url": "https://avatars.githubusercontent.com/u/40774?v=4",
"profile": "https://cloudhead.io/",
"contributions": [
"code",
"doc"
]
},
{
"login": "lukeapage",
"name": "Luke Page",
"avatar_url": "https://avatars.githubusercontent.com/u/309321?v=4",
"profile": "https://github.com/lukeapage",
"contributions": [
"code"
]
},
{
"login": "seven-phases-max",
"name": "Max Mikhailov",
"avatar_url": "https://avatars.githubusercontent.com/u/5304376?v=4",
"profile": "https://github.com/seven-phases-max",
"contributions": [
"code"
]
},
{
"login": "iChenLei",
"name": "Lei Chen",
"avatar_url": "https://avatars.githubusercontent.com/u/14012511?v=4",
"profile": "https://github.com/iChenLei",
"contributions": [
"code",
"bug",
"doc"
]
},
{
"login": "puckowski",
"name": "Daniel Puckowski",
"avatar_url": "https://avatars.githubusercontent.com/u/3059609?v=4",
"profile": "https://github.com/puckowski",
"contributions": [
"code",
"bug"
]
}
],
"contributorsPerLine": 7,
"linkToUsage": true
}
110 changes: 32 additions & 78 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,86 +9,40 @@ on:
branches: [main, master]

jobs:
basic_node_test:
name: 'Basic tests on ubuntu-latest with nodejs v22 (current LTS version)'
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v2
with:
node-version: ${{ matrix.node }}
- name: Install npm dependencies
run: npm install
- name: Print put node & npm version
run: node --version && npm --version
- name: Install chromium
run: npx playwright install chromium
- name: Run unit test
run: npm run test

windows_and_macos_test:
name: 'Platform tests on ${{matrix.os}} with nodejs v${{matrix.node}}'
needs: basic_node_test
test:
name: 'Tests on ${{matrix.os}} with Node "${{matrix.node}}"'
strategy:
matrix:
# Test all mainstream operating system
os: [macos-latest, windows-latest]
node: [22]
runs-on: ${{ matrix.os }}
steps:
# Pull repo to test machine
- uses: actions/checkout@v2
# Configures the node version used on GitHub-hosted runners
- uses: actions/setup-node@v2
with:
# The Node.js version to configure
node-version: ${{ matrix.node }}
- name: Install npm dependencies
run: npm install
- name: Print put node & npm version
# Output useful info for debugging.
run: node --version && npm --version
- name: Install chromium
run: npx playwright install chromium
- name: Run unit test
run: npm run test
# Test all mainstream operating systems
os: [ubuntu-latest, macos-latest, windows-latest]
node: ['current']
include:
- os: ubuntu-latest
node: 'lts/*'
- os: ubuntu-latest
node: 'lts/-1'
- os: ubuntu-latest
node: 'lts/-2'
- os: ubuntu-latest
node: 'lts/-3'

historical_versions_node_test:
name: 'Historical version nodejs v${{matrix.node}} test'
needs: basic_node_test
strategy:
matrix:
os: [ubuntu-latest]
node: [14, 16, 18, 20]
runs-on: ${{ matrix.os }}
# This has copy/paste steps and should be refactored using DRY
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v2
with:
node-version: ${{ matrix.node }}
- name: Install npm dependencies
run: npm install
- name: Print put node & npm version
run: node --version && npm --version
- name: Install chromium
run: npx playwright install chromium
- name: Run unit test
run: npm run test

latest_nodejs_testing_node23:
name: 'Latest nodejs v23 test'
needs: basic_node_test
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v2
with:
node-version: 23
- name: Install npm dependencies
run: npm install
- name: Print put node & npm version
run: node --version && npm --version
- name: Install chromium
run: npx playwright install chromium
- name: Run unit test
run: npm run test
- uses: actions/checkout@v4
- name: Install pnpm
uses: pnpm/action-setup@v4
with:
version: 8
- uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node }}
cache: 'pnpm'
- name: Install dependencies
run: pnpm install
- name: Print put node & npm version
run: node --version && pnpm --version
- name: Install chromium
run: npx playwright install chromium
- name: Run unit test
run: pnpm run test
1 change: 1 addition & 0 deletions .nvmrc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
v16
15 changes: 2 additions & 13 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ Please report documentation issues in [the documentation project](https://github

* Please search for existing feature requests first to see if something similar already exists.
* Include a clear and specific use-case. We love new ideas, but we do not add language features without a reason.
* Consider whether or not your language feature would be better as a function or implemented in a 3rd-party build system such as [assemble-less](http://github.com/assemble/assemble-less).
* Consider whether or not your language feature would be better as a function or implemented in a 3rd-party build system


## Pull Requests
Expand All @@ -51,15 +51,4 @@ Learn more about [developing Less.js](http://lesscss.org/usage/#developing-less)

## Releases

Releases are managed using Lerna. First, we determine if the release is a major (breaking), minor (new features), or patch (bug fix) change.

Then, you can run Lerna with a command like:
```
npx lerna version minor
```

To publish, run the Lerna command for publishing without incrementing the version, as in:
```
npx lerna publish from-package --no-private
```

Releases are managed using PNPM. Instructions TBD
35 changes: 33 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
<p align="center"><img src="http://lesscss.org/public/img/less_logo.png" width="264" height="117">
<!-- ALL-CONTRIBUTORS-BADGE:START - Do not remove or modify this section -->
[![All Contributors](https://img.shields.io/badge/all_contributors-6-orange.svg?style=flat-square)](#contributors-)
<!-- ALL-CONTRIBUTORS-BADGE:END -->

<p align="center">
<a href="https://github.com/less/less.js/actions?query=branch%3Amaster"><img src="https://github.com/less/less.js/actions/workflows/ci.yml/badge.svg?branch=master" alt="Github Actions CI"/></a>
Expand Down Expand Up @@ -39,11 +42,39 @@ See the [changelog](CHANGELOG.md)

## Contributors

### Code Contributors

This project exists thanks to all the people who contribute. [[Contribute](CONTRIBUTING.md)].
<a href="https://github.com/less/less.js/graphs/contributors"><img src="https://opencollective.com/less/contributors.svg?width=890&button=false" /></a>

<!-- ALL-CONTRIBUTORS-LIST:START - Do not remove or modify this section -->
<!-- prettier-ignore-start -->
<!-- markdownlint-disable -->
<table>
<tbody>
<tr>
<td align="center" valign="top" width="14.28%"><a href="https://github.com/matthew-dean"><img src="https://avatars.githubusercontent.com/u/414752?v=4?s=100" width="100px;" alt="Matthew Dean"/><br /><sub><b>Matthew Dean</b></sub></a><br /><a href="https://github.com/The Less CSS Team/Less.js/commits?author=matthew-dean" title="Code">💻</a> <a href="https://github.com/The Less CSS Team/Less.js/commits?author=matthew-dean" title="Documentation">📖</a> <a href="#maintenance-matthew-dean" title="Maintenance">🚧</a> <a href="#projectManagement-matthew-dean" title="Project Management">📆</a></td>
<td align="center" valign="top" width="14.28%"><a href="https://cloudhead.io/"><img src="https://avatars.githubusercontent.com/u/40774?v=4?s=100" width="100px;" alt="Alexis Sellier"/><br /><sub><b>Alexis Sellier</b></sub></a><br /><a href="https://github.com/The Less CSS Team/Less.js/commits?author=cloudhead" title="Code">💻</a> <a href="https://github.com/The Less CSS Team/Less.js/commits?author=cloudhead" title="Documentation">📖</a></td>
<td align="center" valign="top" width="14.28%"><a href="https://github.com/lukeapage"><img src="https://avatars.githubusercontent.com/u/309321?v=4?s=100" width="100px;" alt="Luke Page"/><br /><sub><b>Luke Page</b></sub></a><br /><a href="https://github.com/The Less CSS Team/Less.js/commits?author=lukeapage" title="Code">💻</a></td>
<td align="center" valign="top" width="14.28%"><a href="https://github.com/seven-phases-max"><img src="https://avatars.githubusercontent.com/u/5304376?v=4?s=100" width="100px;" alt="Max Mikhailov"/><br /><sub><b>Max Mikhailov</b></sub></a><br /><a href="https://github.com/The Less CSS Team/Less.js/commits?author=seven-phases-max" title="Code">💻</a></td>
<td align="center" valign="top" width="14.28%"><a href="https://github.com/iChenLei"><img src="https://avatars.githubusercontent.com/u/14012511?v=4?s=100" width="100px;" alt="Lei Chen"/><br /><sub><b>Lei Chen</b></sub></a><br /><a href="https://github.com/The Less CSS Team/Less.js/commits?author=iChenLei" title="Code">💻</a> <a href="https://github.com/The Less CSS Team/Less.js/issues?q=author%3AiChenLei" title="Bug reports">🐛</a> <a href="https://github.com/The Less CSS Team/Less.js/commits?author=iChenLei" title="Documentation">📖</a></td>
<td align="center" valign="top" width="14.28%"><a href="https://github.com/puckowski"><img src="https://avatars.githubusercontent.com/u/3059609?v=4?s=100" width="100px;" alt="Daniel Puckowski"/><br /><sub><b>Daniel Puckowski</b></sub></a><br /><a href="https://github.com/The Less CSS Team/Less.js/commits?author=puckowski" title="Code">💻</a> <a href="https://github.com/The Less CSS Team/Less.js/issues?q=author%3Apuckowski" title="Bug reports">🐛</a></td>
</tr>
</tbody>
<tfoot>
<tr>
<td align="center" size="13px" colspan="7">
<img src="https://raw.githubusercontent.com/all-contributors/all-contributors-cli/1b8533af435da9854653492b1327a23a4dbd0a10/assets/logo-small.svg">
<a href="https://all-contributors.js.org/docs/en/bot/usage">Add your contributions</a>
</img>
</td>
</tr>
</tfoot>
</table>

<!-- markdownlint-restore -->
<!-- prettier-ignore-end -->

<!-- ALL-CONTRIBUTORS-LIST:END -->


## [License](LICENSE)

Expand Down
Loading