Statements must not be empty, except catch blocks #34
Conversation
| declare(strict_types=1); | ||
|
|
||
| if ($foo) { | ||
| // Bar |
There was a problem hiding this comment.
why comments do not count? // a long explanation of why we shouldn't do anything here should suffice?
There was a problem hiding this comment.
Can we find a valid example of this? Will take a look.
There was a problem hiding this comment.
Couldn't find anything locally. Searched Symfony as it's a large codebase, there are a few, such as:
- https://github.com/symfony/symfony/blob/737726516e819fc0b1ea43dc6491bddd6d98b1f4/src/Symfony/Component/DependencyInjection/Container.php#L161-L163
- https://github.com/symfony/symfony/blob/737726516e819fc0b1ea43dc6491bddd6d98b1f4/src/Symfony/Component/Debug/ExceptionHandler.php#L123-L125
- https://github.com/symfony/symfony/blob/737726516e819fc0b1ea43dc6491bddd6d98b1f4/src/Symfony/Component/PropertyAccess/PropertyAccessor.php#L339-L341
- https://github.com/symfony/symfony/blob/737726516e819fc0b1ea43dc6491bddd6d98b1f4/src/Symfony/Bridge/PhpUnit/DeprecationErrorHandler.php#L120-L122
I think this cases are all avoidable (by returning early etc), but maybe this should just be something for code review.
There was a problem hiding this comment.
These examples are what I had in mind, they are edge cases of complex code
There was a problem hiding this comment.
Going to ignore for now. If there really is a situation where it makes sense, then we can revisit/disable that individual check.
No description provided.