Skip to content

Fixes a trio of concurrency issues found by Coverity #1079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 8, 2015
Merged

Fixes a trio of concurrency issues found by Coverity #1079

merged 1 commit into from
Jun 8, 2015

Conversation

whoisj
Copy link

@whoisj whoisj commented Jun 8, 2015

The new-again Coverity scanning @nulltoken setup recently has started to bear fruit. The first items reported and tackled are these concurrency issues. Minor fixes, low risk.

  1. Don't check thread-shared variables outside of critical-sections.
  2. Don't process potentially long chains of thread-shared data without a mutex.

@nulltoken
Copy link
Member

@whoisj Could you please stop reading my mind, please? I was just working on those. 😝

nulltoken added a commit that referenced this pull request Jun 8, 2015
Fixes a trio of concurrency issues found by Coverity
@nulltoken nulltoken merged commit 7cb2d7e into libgit2:vNext Jun 8, 2015
@nulltoken nulltoken added this to the v0.22 milestone Jun 8, 2015
@nulltoken
Copy link
Member

@whoisj 😍

@whoisj whoisj deleted the fix-coverity-concurrency-issues branch June 10, 2015 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants