Topic/path and patch #702
Topic/path and patch #702
Conversation
|
Looks good to me. @sergiodebst will this address your need? |
|
Yes, great, thanks! |
| } | ||
|
|
||
| /// <summary> | ||
| /// The new path. |
There was a problem hiding this comment.
If the path participated in a rename? Do we need NewPath and OldPath?
There was a problem hiding this comment.
Well, Path and OldPath, to align with TreeEntryChanges. Though really, I could argue that PatchContentChanges should include all the properties from TreeEntryChanges.
There was a problem hiding this comment.
👍 @dahlbyk spike coming this way
|
The last commit is a spike showing what would we end up with if In order to avoid duplication, some building logic has been move to the I will add more tests later if you're Ok with this spike. |
|
I like this. |
|
👍 as well. Could you please squash and rebase? |
Actually squash only the "Spike" one. I kind of like your separate "cleanup" commit" ;-) |
|
@yorah Ping? |
|
I can fetch and squash if needed. |
Exposes same properties than TreeEntryChanges through composition
... pong ! Sorry for the delay, squashed and pushed. |
|
@yorah ❤️ |
Fixes #686
I also added a cleanup commit on the fixture file I was modifying. Tell me if you want me to drop it 😉