Skip to content

Signature default encoding? #581

Closed
Closed
@bors-ltd

Description

@bors-ltd

Hi,

It's not documented but it seems the default encoding for the signature name is ASCII: https://github.com/libgit2/pygit2/blob/master/src/signature.c#L41

Is there a particular reason why it's not UTF-8, like about everything else in git/libgit2?

When I pass a unicode/text object, I wouldn't expect to provide the encoding as well (there is an accent in my name).

Especially when it seems to be the default for internally built signatures: https://github.com/libgit2/pygit2/blob/master/src/signature.c#L114

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions