Closed
Description
I'm getting that if you pass a 40-character string SHA to repo.descendant_of()
that doesn't correspond to a commit (for either argument), then the function always returns True
. I haven't verified, but it looks like it could be because of this line:
Line 593 in 976450a
The PyBool_FromLong()
converts an error code to True
. Instead, an error code should result in an exception IMO.