Skip to content

ref.log() crashes on the reflog created by Repository.references.create() #901

Closed
@cjerdonek

Description

@cjerdonek

If you create a new reference using Repository.references.create(), then an invalid (corrupt) reflog file gets created (e.g. can't be read by ref.log()).

This looks to be because e.g. Repository_create_reference_direct passes NULL to git_reference_create() as the log_message argument:

err = git_reference_create(&c_reference, self->repo, c_name, &oid, force, NULL);

And similarly for Repository_create_reference_symbolic:

pygit2/src/repository.c

Lines 1527 to 1528 in c43db44

err = git_reference_symbolic_create(&c_reference, self->repo, c_name,
c_target, force, NULL);

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions