Skip to content

Improved type hinting in Branches, References #1132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 14, 2022
Merged

Improved type hinting in Branches, References #1132

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions pygit2/repository.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1489,7 +1489,7 @@ def amend_commit(self, commit, refname, author=None,

class Branches:

def __init__(self, repository, flag=GIT_BRANCH_ALL, commit=None):
def __init__(self, repository: BaseRepository, flag: int = GIT_BRANCH_ALL, commit=None):
self._repository = repository
self._flag = flag
if commit is not None:
Expand All @@ -1503,7 +1503,7 @@ def __init__(self, repository, flag=GIT_BRANCH_ALL, commit=None):
self.local = Branches(repository, flag=GIT_BRANCH_LOCAL, commit=commit)
self.remote = Branches(repository, flag=GIT_BRANCH_REMOTE, commit=commit)

def __getitem__(self, name):
def __getitem__(self, name: str):
branch = None
if self._flag & GIT_BRANCH_LOCAL:
branch = self._repository.lookup_branch(name, GIT_BRANCH_LOCAL)
Expand All @@ -1516,7 +1516,7 @@ def __getitem__(self, name):

return branch

def get(self, key):
def get(self, key: str):
try:
return self[key]
except KeyError:
Expand All @@ -1527,10 +1527,10 @@ def __iter__(self):
if self._commit is None or self.get(branch_name) is not None:
yield branch_name

def create(self, name, commit, force=False):
def create(self, name: str, commit, force=False):
return self._repository.create_branch(name, commit, force)

def delete(self, name):
def delete(self, name: str):
self[name].delete()

def _valid(self, branch):
Expand All @@ -1553,13 +1553,13 @@ def __contains__(self, name):

class References:

def __init__(self, repository):
def __init__(self, repository: BaseRepository):
self._repository = repository

def __getitem__(self, name):
def __getitem__(self, name: str):
return self._repository.lookup_reference(name)

def get(self, key):
def get(self, key: str):
try:
return self[key]
except KeyError:
Expand All @@ -1572,10 +1572,10 @@ def __iter__(self):
def create(self, name, target, force=False):
return self._repository.create_reference(name, target, force)

def delete(self, name):
def delete(self, name: str):
self[name].delete()

def __contains__(self, name):
def __contains__(self, name: str):
return self.get(name) is not None

@property
Expand Down